feat!: move DECAF_ROOT_WORKING_DIRECTORY env var to input script data - #204
feat!: move DECAF_ROOT_WORKING_DIRECTORY env var to input script data#204levibostian wants to merge 3 commits into
Conversation
As I was looking through the Decaf SDK code, I was trying to find all of the code that the SDK has to keep in sync with Decaf. If DCF changes something, then we would break the SDK. The goal is that the SDK breaks as little as possible and is always backwards compatible with DCF. I then looked at all environment variables that they have to keep in sync, and I found this one. I think that actually it was the wrong move to make this an environment variable and instead it should be a part of the input data because the entire design pattern of Decaf is that we pass everything to you that you need with JSON, and then you give us back everything we need with JSON. So I feel like this also needs to follow that pattern.
decafRunning deployments in test mode. Results will appear below. ...🟩 squash 🟩 merge method... 🚢 The next version of the project will be: 1.0.0 Learn moreLatest release: 0.17.3 Commit of latest release: 565688d Commits since last release: - feat!: move DECAF_ROOT_WORKING_DIRECTORY env var to input script data As I was looking through the Decaf SDK code, I was trying to find all of the code that the SDK has to keep in sync with Decaf. If DCF changes something, then we would break the SDK. The goal is that the SDK breaks as little as possible and is always backwards compatible with DCF. I then looked at all environment variables that they have to keep in sync, and I found this one. I think that actually it was the wrong move to make this an environment variable and instead it should be a part of the input data because the entire design pattern of Decaf is that we pass everything to you that you need with JSON, and then you give us back everything we need with JSON. So I feel like this also needs to follow that pattern. Related GitHub Issues<!-- Link to any related GitHub issues that this pull request addresses or closes. --> Problem<!-- A clear description of the problem that this pull request is solving. --> Solution<!-- Describe the approach you took to solve the problem and the changes made in this pull request. --> Testing<!-- Choose one of the below options for how you tested the code change. Include any specific setup or instructions for testing. -->
The automated test suite has been updated with essentially a refactor where we're swapping an environment variable for input data. Along with that, we are using this pull request to ensure that everything works as expected. Some of the decaf scripts will need to be changed because of this, so this pull request will be a good test for that. Notes for reviewers<!-- If there is any additional information you would like to share with the person reviewing this pull request, please provide it here. --> Currently in draft until I edit my decaf scripts to confirm this is an OK change to make. ...🟩 rebase 🟩 merge method... |
As I was looking through the Decaf SDK code, I was trying to find all of the code that the SDK has to keep in sync with Decaf. If DCF changes something, then we would break the SDK. The goal is that the SDK breaks as little as possible and is always backwards compatible with DCF.
I then looked at all environment variables that they have to keep in sync, and I found this one. I think that actually it was the wrong move to make this an environment variable and instead it should be a part of the input data because the entire design pattern of Decaf is that we pass everything to you that you need with JSON, and then you give us back everything we need with JSON.
So I feel like this also needs to follow that pattern.
Related GitHub Issues
Problem
Solution
Testing
The automated test suite has been updated with essentially a refactor where we're swapping an environment variable for input data. Along with that, we are using this pull request to ensure that everything works as expected. Some of the decaf scripts will need to be changed because of this, so this pull request will be a good test for that.
Notes for reviewers
Currently in draft until I edit my decaf scripts to confirm this is an OK change to make.