Add classname validation to edit configuration context#65
Open
Nick Amoscato (namoscato) wants to merge 2 commits intolensesio:masterfrom
Open
Add classname validation to edit configuration context#65Nick Amoscato (namoscato) wants to merge 2 commits intolensesio:masterfrom
Nick Amoscato (namoscato) wants to merge 2 commits intolensesio:masterfrom
Conversation
added 2 commits
February 10, 2018 12:49
Starts consolidating configuration validation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This starts to consolidate validation behavior across create and edit contexts:
connector.classcan technically be changed (to another valid classname) when updating a connector, but this behavior was previously prevented, so I kept the functionality the same, which mimics the create context as well.This change is