Repository navigation
Conversation
Member
|
Can you bump the pygeomtools requirement in pyproject.toml? |
Contributor
Author
|
yes, i would also wait before merging this PR. There has been conflicting information from Bernhard regarding the insulation recently... |
EricMEsch
marked this pull request as draft
October 27, 2026 18:32
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds the jackodur insulation as optional assembly piece. It is placed per default on the
cosmogenicdetail level. If it is placed, the jackodur will be the mothervolume placed in the watertank and the cryo will be placed inside the jackodur. It is a 1 cm thick envelope of the entire cryo. Only at the top where the reentrance tube leaves the watertank, it is reduced to 1 nm for the geant4 navigator. Following should show all important parts:this pr is built on top of #145.
It also requires a new pygeomtools version with the jackodur material.