docs(contributing): update JDK requirement and KDoc URLs - #2241
Open
RohithPariki wants to merge 1 commit into
Open
docs(contributing): update JDK requirement and KDoc URLs#2241RohithPariki wants to merge 1 commit into
RohithPariki wants to merge 1 commit into
Conversation
RohithPariki
marked this pull request as ready for review
September 4, 2026 02:02
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
docs/CONTRIBUTING.mdstated that developers must use JDK 17 based on an outdated AGP requirement from issue AGP 8.1.0 requires the developer to use JDK 17 on Gradle JDK #74 ([FR]: Update stale JDK version requirement in CONTRIBUTING.md #2107).catalog/src/main/kotlin/com/adevinta/spark/catalog/util/Url.ktpointedDocsUrlandPackageSummaryUrltoadevinta.github.io/spark-androidwhich causes 404s/wrong project links instead of the currentleboncoin.github.io/spark-androiddeployment ([FR]: Fix KDoc URL pointing to wrong GitHub org in README #2105).Root Cause
leboncoinGitHub organization when repository ownership transitioned.Solution
docs/CONTRIBUTING.mdto directly specify that JDK 17 or later is required to build the project and run the Gradle daemon, removing the stale issue AGP 8.1.0 requires the developer to use JDK 17 on Gradle JDK #74 reference.DocsUrlandPackageSummaryUrlinUrl.ktto point tohttps://leboncoin.github.io/spark-androidandhttps://leboncoin.github.io/spark-android/spark.Testing
docs/CONTRIBUTING.md.Url.kt.Risk
Zero runtime risk; documentation and catalog link update only.
Issue
Closes #2107
Closes #2105