Skip to content

docs(contributing): update JDK requirement and KDoc URLs - #2241

Open
RohithPariki wants to merge 1 commit into
leboncoin:mainfrom
RohithPariki:docs/issue-2107-jdk-requirement
Open

docs(contributing): update JDK requirement and KDoc URLs#2241
RohithPariki wants to merge 1 commit into
leboncoin:mainfrom
RohithPariki:docs/issue-2107-jdk-requirement

Conversation

@RohithPariki

@RohithPariki RohithPariki commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Problem

  1. docs/CONTRIBUTING.md stated that developers must use JDK 17 based on an outdated AGP requirement from issue AGP 8.1.0 requires the developer to use JDK 17 on Gradle JDK #74 ([FR]: Update stale JDK version requirement in CONTRIBUTING.md #2107).
  2. catalog/src/main/kotlin/com/adevinta/spark/catalog/util/Url.kt pointed DocsUrl and PackageSummaryUrl to adevinta.github.io/spark-android which causes 404s/wrong project links instead of the current leboncoin.github.io/spark-android deployment ([FR]: Fix KDoc URL pointing to wrong GitHub org in README #2105).

Root Cause

Solution

  • Updated docs/CONTRIBUTING.md to directly specify that JDK 17 or later is required to build the project and run the Gradle daemon, removing the stale issue AGP 8.1.0 requires the developer to use JDK 17 on Gradle JDK #74 reference.
  • Updated DocsUrl and PackageSummaryUrl in Url.kt to point to https://leboncoin.github.io/spark-android and https://leboncoin.github.io/spark-android/spark.

Testing

  • Verified Markdown formatting in docs/CONTRIBUTING.md.
  • Verified URL validity in Url.kt.

Risk

Zero runtime risk; documentation and catalog link update only.

Issue

Closes #2107
Closes #2105

@RohithPariki
RohithPariki marked this pull request as ready for review September 4, 2026 02:02
@RohithPariki
RohithPariki requested review from a team and soulcramer as code owners September 4, 2026 02:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FR]: Update stale JDK version requirement in CONTRIBUTING.md [FR]: Fix KDoc URL pointing to wrong GitHub org in README

1 participant