-
-
Notifications
You must be signed in to change notification settings - Fork 301
Update the public ChannelMetadata viewset to support token filter #5715
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
taoerman
wants to merge
6
commits into
learningequality:unstable
Choose a base branch
from
taoerman:issue-5462-Update-the-public-ChannelMetadata-viewset-to-support-token-filter
base: unstable
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 3 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
b179b9d
Update the public ChannelMetadata viewset to support token filter
taoerman 34767cd
[pre-commit.ci lite] apply automatic fixes
pre-commit-ci-lite[bot] 8a66e73
fix linting
taoerman 3037996
fix code
taoerman 4636045
[pre-commit.ci lite] apply automatic fixes
pre-commit-ci-lite[bot] 235358a
fix code
taoerman File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @taoerman! It seems there has been a misunderstanding here, for this spec:
We should get the data from the contentcuration models, because the channels we will import using tokens are private, not public, this is why we can't retrieve them from the public models like this
return models.ChannelMetadata.objects.filter(id__in=channel_ids), we will need to get the data from the private models, and annotate/adapt the fields that are different/missing on the public models. As a result, we should get an annotated queryset that complies with the api that we are exposing in the viewset values fieldThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the clarification! You're right - the original implementation incorrectly queried private models but then filtered the public ChannelMetadata table, which doesn't work for private channels that don't exist in the public database. I've fixed this by updating get_queryset_from_token() to return Channel querysets directly and overriding serialize() to transform the field mappings appropriately (e.g., main_tree → root, language → lang), ensuring private channels can be accessed via tokens without requiring them to exist in the public ChannelMetadata table. All tests are passing!