Repository navigation
fix browserpod navbar cutting off its right side - #479
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small navbar fix. The navbar still layout was inherited from the other product sites, but it's own navbar is not nearly as wide. The items only just fit with no space left over, so on machines with wider text rendering (like mine) the Discord and GitHub star counts got clipped.
Fixes:
-The pill now fills its 1024px max width instead of sizing to its contents, and on smaller windows it keeps a 16px margin on each side so it never extends past the window.
-Below 1024px window width, hides the Discord and GitHub counts (the icons stay).
-Below 768px, tightens the padding on the nav links.
limitations / future work