fix: Do not emit a redundant ready event during initialization

src/main/java/com/launchdarkly/openfeature/serverprovider/Provider.java

@@ -51,6 +51,8 @@ public String getName() {
 
     private final Object stateLock = new Object();
 
+    private volatile boolean initializing = false;
+
     /**
      * Create a provider with the specified SDK and default configuration.
      * <p>
@@ -152,6 +154,7 @@ public void initialize(EvaluationContext evaluationContext) throws Exception {
             setState(ProviderState.READY);
         }
 
+        initializing = true;
         var completer = new CompletableFuture<Boolean>();
 
         client.getFlagTracker().addFlagChangeListener(detail -> {
@@ -164,11 +167,17 @@ public void initialize(EvaluationContext evaluationContext) throws Exception {
         });
 
         if (getState() == ProviderState.READY) {
+            initializing = false;
             return;
         }
 
-        handleDataSourceStatus(client.getDataSourceStatusProvider().getStatus(), completer);
-        var successfullyInitialized = completer.get();
+        boolean successfullyInitialized;
+        try {
+            handleDataSourceStatus(client.getDataSourceStatusProvider().getStatus(), completer);
+            successfullyInitialized = completer.get();
+        } finally {
+            initializing = false;
+        }
 
         if(!successfullyInitialized) {
             throw new RuntimeException("Failed to initialize LaunchDarkly client.");
@@ -200,8 +209,12 @@ private void handleDataSourceStatus(DataSourceStatusProvider.Status res, Complet
                 }
 
                 if (emit) {
+                    // The OpenFeature SDK emits its own ready event when initialization succeeds.
+                    boolean duringInitialization = initializing;
                     completer.complete(true);
-                    emitProviderReady(ProviderEventDetails.builder().build());
+                    if (!duringInitialization) {
+                        emitProviderReady(ProviderEventDetails.builder().build());
+                    }
                 }
             }
             break;

src/test/java/com/launchdarkly/openfeature/serverprovider/LifeCycleTest.java

@@ -104,6 +104,29 @@ public void close() throws IOException {
     }
 }
 
+class ControllableDataSource implements DataSource {
+    public Future<Void> start() {
+        return new CompletableFuture<>();
+    }
+
+    public boolean isInitialized() {
+        return false;
+    }
+
+    public void close() throws IOException {
+    }
+}
+
+class ControllableDataSourceFactory implements ComponentConfigurer<DataSource> {
+    final CompletableFuture<DataSourceUpdateSink> sink = new CompletableFuture<>();
+
+    @Override
+    public DataSource build(ClientContext clientContext) {
+        sink.complete(clientContext.getDataSourceUpdateSink());
+        return new ControllableDataSource();
+    }
+}
+
 class DelayedDataSourceFactory implements ComponentConfigurer<DataSource> {
     private Duration startDelay;
     private boolean willError;
@@ -219,14 +242,19 @@ public void itCanHandleClientThatIsNotInitializedImmediately() throws Exception
         assertEquals(ProviderState.NOT_READY, provider.getState());
 
         var readyCount = new AtomicInteger();
+        CompletableFuture<Boolean> gotReadyEvent = new CompletableFuture<>();
 
         OpenFeatureAPI.getInstance().on(ProviderEvent.PROVIDER_READY, (detail) -> {
             readyCount.getAndIncrement();
+            gotReadyEvent.complete(true);
         });
 
         OpenFeatureAPI.getInstance().setProviderAndWait(provider);
 
         assertEquals(ProviderState.READY, provider.getState());
+        assertTrue(gotReadyEvent.get(1000, TimeUnit.MILLISECONDS));
+
+        Thread.sleep(100);
         assertEquals(1, readyCount.get());
     }
 
@@ -260,6 +288,54 @@ public void itCanHandleClientThatIsNotInitializedImmediatelyAndErrors() throws E
         assertTrue(gotErrorEvent.get(1000, TimeUnit.MILLISECONDS));
     }
 
+    @Test
+    public void itEmitsReadyWhenTheDataSourceRecoversFromAFailedInitialization() throws Exception {
+        var dataSourceFactory = new ControllableDataSourceFactory();
+        var config = new LDConfig.Builder()
+            .startWait(Duration.ZERO)
+            .dataSource(dataSourceFactory)
+            .events(Components.noEvents())
+            .build();
+        var provider = new Provider("fake-key", config);
+        var sink = dataSourceFactory.sink.get(1000, TimeUnit.MILLISECONDS);
+
+        var readyCount = new AtomicInteger();
+        CompletableFuture<Boolean> gotReadyEvent = new CompletableFuture<>();
+        CompletableFuture<Boolean> gotErrorEvent = new CompletableFuture<>();
+
+        OpenFeatureAPI.getInstance().on(ProviderEvent.PROVIDER_READY, (detail) -> {
+            readyCount.getAndIncrement();
+            gotReadyEvent.complete(true);
+        });
+
+        OpenFeatureAPI.getInstance().on(ProviderEvent.PROVIDER_ERROR, (detail) -> {
+            gotErrorEvent.complete(true);
+        });
+
+        sink.updateStatus(DataSourceStatusProvider.State.OFF, new DataSourceStatusProvider.ErrorInfo(
+            DataSourceStatusProvider.ErrorKind.NETWORK_ERROR,
+            404,
+            "bad",
+            LocalDateTime.now().toInstant(ZoneOffset.UTC)));
+
+        GeneralError initializationError = null;
+        try {
+            OpenFeatureAPI.getInstance().setProviderAndWait(provider);
+        } catch (GeneralError e) {
+            initializationError = e;
+        }
+
+        assertNotNull(initializationError);
+        assertTrue(gotErrorEvent.get(1000, TimeUnit.MILLISECONDS));
+
+        sink.updateStatus(DataSourceStatusProvider.State.VALID, null);
+
+        assertTrue(gotReadyEvent.get(1000, TimeUnit.MILLISECONDS));
+
+        Thread.sleep(100);
+        assertEquals(1, readyCount.get());
+    }
+
     @Test
     public void itIncludesTheDataSourceErrorInErrorEvents() throws Exception {
         var config = new LDConfig.Builder()