[REL-7521] Rel 7521 fix bug in ld vs code integration setup process - #131
Conversation
…e headers. updated broken links
There was a problem hiding this comment.
Pull Request Overview
This PR fixes authentication and session management issues in the LaunchDarkly VS Code extension, improving the setup process and adding proper session cleanup functionality.
- Fixes auth failure scenarios with no retry mechanism and improves error handling
- Adds sign out functionality with proper session cleanup
- Updates dependencies (Axios to v1.6.0) and build process
Reviewed Changes
Copilot reviewed 17 out of 19 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/utils/commands.ts | Updates command constants for sign-in and adds sign-out command |
| src/providers/authProvider.ts | Improves session validation, error handling, and adds proper session cleanup |
| src/extension.ts | Adds sign-in/sign-out command handlers with better error handling |
| src/generalUtils.ts | Adds session cleanup function and improves component management |
| src/api.ts | Updates to use modern Axios import and improves error handling |
| package.json | Updates Axios dependency and adds sign-out command configuration |
| README.md | Adds authentication instructions and development setup guide |
Comments suppressed due to low confidence (1)
package.json:1
- The dependency "tree-sitter-stack-graphs" is being removed but the line shows it's still present. This appears to be an incomplete removal.
{
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
monsagri
left a comment
There was a problem hiding this comment.
I think this looks really good!
Ran it locally and it definitely works for me
One recommendation I would have is to also update the release workflow for GHA - I think it'll attempt to run once we merge this and fail since we haven't upgraded the actions it uses to v4 yet
ldhenry
left a comment
There was a problem hiding this comment.
Looks good to me. Thanks for your help on this!
Problems to solve:
Changes:
Related Jira issue: REL-7521: Fix bug in LD VS Code Integration setup process