fix: add X-LaunchDarkly-Instance-Id to browser CORS allowlist - #735
Draft
keelerm84 wants to merge 1 commit into
Draft
fix: add X-LaunchDarkly-Instance-Id to browser CORS allowlist#735keelerm84 wants to merge 1 commit into
keelerm84 wants to merge 1 commit into
Conversation
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requirements
Related issues
Port of #734 (v8) to v9.
Describe the solution you've provided
Adds
X-LaunchDarkly-Instance-Idtobrowser.DefaultAllowedHeaders— theAccess-Control-Allow-Headersvalue for the browser JS subrouter.This keeps Relay consistent with what underlying backend systems now advertise and avoids dropped browser preflights if a browser JS SDK begins sending the header.
Describe alternatives you've considered
N/A — identical change to #734.
Additional context
Existing CORS tests reference
DefaultAllowedHeaderssymbolically, so they cover the new value automatically.Link to Devin session: https://app.devin.ai/sessions/57c97daf9ab24e6fae8fa5ff01c2267a
Requested by: @keelerm84