Fix an issue with parsing headers with 'kid' - #395
Merged
Conversation
When verifying a JWS against a JWKSet, check for the 'kid' parameter in chk_hdrs instead of self.jose_header. This ensures that key lookup works properly for signatures that define 'kid' in unprotected headers or when processing multiple signatures. Assisted-by: Gemini:Gemini 3.7 Flash Signed-off-by: Simo Sorce <simo@redhat.com>
Update JWE header parsing and decryption to properly support objects with multiple recipients. The `jose_header` property now returns a list of headers when multiple recipients exist, and JWKSet key lookups now evaluate the individual recipient's header rather than the top-level property. Additionally, allow `_get_jose_header` to accept headers that are already decoded as dictionaries. Assisted-by: Gemini:Gemini 3.7 Flash Signed-off-by: Simo Sorce <simo@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This addresses an issue with JWS reported by @1321284827 and also brings up the related JWE feature to properly handle kid in per-recipient headers just like we support kid for multiple JWS signatures.
In both cases we had issues, but the JWE case was non-functional, while the JWS cases was problematic.