Skip to content

generate cron refactoring - #92

Merged
landsman merged 7 commits into
devfrom
feat/cron-deploy
Apr 23, 2026
Merged

landsman merged 7 commits into
devfrom
feat/cron-deploy

Conversation

@landsman

Copy link
Copy Markdown
Owner

No description provided.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request automates cron job deployment and enhances security by migrating from hardcoded anon keys to Supabase Vault. Key changes include a new Architecture Decision Record (ADR), refactored SQL generation logic in the cron utility to fetch secrets at runtime, and a new Makefile target for generating migrations. Feedback focuses on correcting a future date typo in the ADR, restricting Deno permissions in the Makefile to follow the principle of least privilege, and adding unit tests for the refactored SQL utility functions to replace the ones that were removed.

Comment thread Makefile Resolved
Comment thread supabase/functions/_shared/cron.ts Resolved
@github-actions

Copy link
Copy Markdown

Deno Outdated - Supabase

Package Current Update Latest
jsr:@supabase/supabase-js 2.104.0 2.104.0 3.0.0-next.3
npm:lucide-react 0.577.0 0.577.0 1.8.0
npm:react 19.2.4 19.2.4 19.2.5
npm:react-dom 19.2.4 19.2.4 19.2.5
npm:@deno/vite-plugin 1.0.6 1.0.6 2.0.2
npm:@lingui/babel-plugin-lingui-macro 5.9.5 5.9.5 6.0.0
npm:@lingui/core 5.9.5 5.9.5 6.0.0
npm:@lingui/detect-locale 5.9.5 5.9.5 6.0.0
npm:@lingui/react 5.9.5 5.9.5 6.0.0
npm:@lingui/vite-plugin 5.9.5 5.9.5 6.0.0
npm:@vitejs/plugin-react 5.2.0 5.2.0 6.0.1
npm:vite 7.3.2 7.3.2 8.0.10

@landsman
landsman merged commit fc19861 into dev Apr 23, 2026
1 check passed
@landsman
landsman deleted the feat/cron-deploy branch April 23, 2026 12:24

This branch was previously deployed

1 inactive deployment
test — 28e5df39 Deployed Apr 23, 2026 by landsman via QA #88
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant