Repository navigation
generate cron refactoring - #92
Merged
Merged
Conversation
There was a problem hiding this comment.
Code Review
This pull request automates cron job deployment and enhances security by migrating from hardcoded anon keys to Supabase Vault. Key changes include a new Architecture Decision Record (ADR), refactored SQL generation logic in the cron utility to fetch secrets at runtime, and a new Makefile target for generating migrations. Feedback focuses on correcting a future date typo in the ADR, restricting Deno permissions in the Makefile to follow the principle of least privilege, and adding unit tests for the refactored SQL utility functions to replace the ones that were removed.
Deno Outdated - Supabase
|
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.