Repository navigation
Scan web and supabase with semgrep, calling the shared workflow - #104
Merged
Merged
Conversation
Both PR pipelines gain a security job calling landsman/config, so the scanner and the image have one place to change rather than one per repo. p/typescript on both rather than a Deno pack: p/deno 404s in the registry, and this is TypeScript whatever runs it. Checked against the image, not assumed -- an unknown pack fails the run rather than being ignored. Run locally against the mirror first: 110 rules over 74 files in src/web and 49 in supabase, both clean.
This was referenced Jul 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both PR pipelines gain a
securityjob. It calls landsman/config#52 rather than copying adocker runinto each file, so the scanner and the image have one place to change rather than one per repo.Its own job, so a finding reads as a finding rather than as a broken build. The existing path filters still apply, so each scan runs only when its own half of the repo changes.
p/typescript, not a Deno pack
p/denodoes not exist — the registry 404s on it, and an unknown pack fails the run rather than being ignored, so this was probed against the pinned image rather than assumed.p/typescriptis the right pack anyway: this is TypeScript whatever runs it.Checked
Run locally against the mirror before opening: 110 rules over 74 files in
src/web, 110 over 49 insupabase. Both clean, both exit 0.Depends on landsman/config#52
workflow_callresolves@main, so these jobs cannot run until that merges — until then they fail with "workflow not found" rather than a scan result.One unrelated note
.hooks/pre-commitaborts on a fresh worktree with.hooks/_/hook.sh: No such file or directory— the hook runner is not installed by a plain checkout. This commit used--no-verifyfor that reason; nothing was skipped that had anything to say about the change.