Repository navigation
fe: give macos its own stylesheet, its rules were scattered through the theme - #266
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
macOS's rules were scattered through
tokens.css,base.cssandtables.css, while Windows has one file. They now sit inmac-os.css, whichTheme::cssMap()loads on macOS only, as it doeswindows-os.csson Windows.window.cssstays: it follows the frameless window from the launcher, not the OS class.Moving rules behind the rest of the theme can change who wins the cascade, so this was compared rather than assumed: every element's computed style in WebKit, before and after, on 6 pages in light and dark, titled and with
.ad-framelessadded by hand, 16,800 elements with no differences. Two runs on main also matched each other. A simulated Linux or Windows no longer picks up the macOS accent..mac-os body { -webkit-font-smoothing: antialiased }moved as it was and looks dead, since the class is on<body>itself. Fixing it changes how text renders on macOS, so it is left for a change of its own.The theme's README is rewritten with a heading, the files, the schemes and the body classes.
make qa,make checkandmake e2epass on macOS.