Repository navigation
fe: dress the app as windows 11 there, it read as a web page in a window - #265
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Windows the app wore the theme's own indigo and web-sized controls, so it read as a web page in a window.
windows-os.cssgives it Windows 11's colours, type, corners and control states, with values read from WinUI's resources rather than from guidelines or screenshots.Theme::cssMap()loads it on Windows only, right after our design and never over a gallery design.make debugnow asks which OS to look like, because that branch cannot otherwise run on a Mac. The choice is ignored without-debug, and it changes the look and the window only (Os::look()): data directories and printed commands stay on the real OS.os-mac,os-windowsandos-linuxbecamemac-os,windows-osandlinux-os, since one line builds all three.Nothing here has run on Windows. It was checked in Chromium and through the debug simulation on macOS, where Segoe UI is missing, so the font and WebView2's scrollbars still need a look on a real machine. The accent is Windows' default until the launcher passes the user's, and the title bar still follows the OS rather than the in-app Light/Dark choice.
make qa,make checkandmake e2epass on macOS. No e2e scenario coverswindows-os.css.