Repository navigation
fe: move the window from the band above an open modal, its backdrop blocked the only place to grab - #260
Merged
Conversation
…locked the only place to grab
landsman
commented
Nov 1, 2026
landsman
left a comment
landsman
left a comment
Owner
Author
There was a problem hiding this comment.
No blocking bug; the two comments below can go in a follow-up. Reviewed by reading the code at 3fca376, nothing was run locally and the drag was not tried by hand.
Checked and fine: the native dragWindow accepts LeftMouseDragged, so the call from mousemove works and a quick click cannot stick the window to the pointer; preventDefault() keeps the click and the dialog's focus; moving the button and full screen checks changes nothing; pages without a modal, non-modal dialogs and stacked dialogs behave as they should.
…r closes on a click outside
…he next drag move the window
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With a modal open, the mouse handler refused every drag, so the window could not be moved at all: the title bar is replaced by the page, and the page was all behind the backdrop.
A press on the backdrop within the title bar band now moves the window. The drag starts only after the pointer has moved 3px, because a window drag takes the release, and a dialog that closes on a click outside still has to get that click. Presses inside the dialog and below the band behave as before.
make qapasses. The fullmake e2epasses all ofwindow.feature, including new scenarios for a drag, a click that closes a light-dismiss dialog, and a lost release; two scenarios elsewhere fail intermittently (settings.feature:43,connections.feature:74), the first of them without this change too. Dragging was checked by hand in the app on macOS, before the lost-release check was added.