Repository navigation
devops: move the i18n generator to app/cli, a script in cli/ has no test and no class - #257
Merged
Merged
Conversation
… php one-liner per command
…art from what it runs
landsman
force-pushed
the
devops/move-php-cli
branch
from
October 31, 2026 23:29
c607c21 to
e069ffb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cli/i18n.phpran its coverage gate inline before callingexit, so nothing could check that the gate fails. It is nowDesktop\Cli\Command\I18n, followingWindowsIcofrom #254, andtests/cli/I18nTest.phpcovers a missing translation and a malformed ID.The Makefile now calls build tooling as
$(CLI) i18n, throughapp/cli/run.php, instead of aphp-cli -rone-liner per command;WindowsIcomoved onto it and intoDesktop\Cli\Command\too. No new dependency.make i18nandmake i18n-checkbehave as before, andapp/cli/still does not ship.make qa,make checkandmake i18n-checkpass. Onemake e2erun ended at 167 of 173, with failures inshell/mcp,shell/connectionsandshell/settings. Those were not investigated and the run was not repeated.