Repository navigation
Conversation
…e workflow at startup
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #249
Upstream's frankenphp is 89 of the 96 MiB in the macOS zip and carries 80 PHP extensions. This adds a builder with
FRANKEN_EXTENSIONSonly (25 asked for), for Linux x86_64, Linux aarch64 and macOS arm64, in the upstream builder's container on Linux and withbuild-static.shon macOS.A pull request that touches the builder only measures: the size lands in the job summary and nothing is published. A manual dispatch pushes to
ghcr.io/landsman/adminer-desktop/frankenphpand attests the digest. Nothing uses the binary yet:make fetch,make verifyand the packages stay on upstream's until the sizes decide it.Measured locally on Linux aarch64,
wc -candgzip -6:XCADDY_ARGSnomercureis in the build but not measured: Mercure stays otherwise, because frankenphp's own Caddy module imports it. This PR's run gives the first number for it, and the first for macOS.The extension list is not proven against the app. The local builds only booted and served a test page through
launcher/Caddyfile;make check,make qaandmake e2ehave not run on such a binary, and they must before anything switches to it.Verified with
make qa, shellcheck, actionlint andtests/cli/build-frankenphp-test.sh, seen failing once with the extension match loosened.make e2ewas not run, as no app code changed. The publish path has never run:orasis only stubbed in the test.