feat: smart saveTo with full path support#62
Open
mikesoennichsen wants to merge 4 commits intomainfrom
Open
Conversation
saveTo now accepts either a directory path (auto-generates filename as
{input_file}_{method}_output.json) or a full file path ending in .json
(saves to that exact path). Parent directories are created automatically.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
Adds “smart” saveTo handling so callers can either provide an output directory (existing behavior) or an explicit .json filepath (new behavior), improving usability for chained workflows without an input filename.
Changes:
- Update
_saveResponseto detectsaveToending with.jsonand write to that exact file path (creating parent dirs as needed). - Preserve directory-mode behavior when
saveTois not a.jsonpath (auto-generated output filename). - Add tests covering exact-path mode, parent directory creation, and JSON formatting.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
src/client.ts |
Implements exact .json path support in _saveResponse while preserving directory mode. |
tests/save-to.test.ts |
Adds coverage for the new .json full-path saving behavior. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
When no input filename can be derived (e.g. raw markdown string), the
auto-generated name is now {method}_output.json instead of the redundant
output_{method}_output.json.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
saveTonow accepts a full file path ending in.jsonin addition to a directory path.Companion PR: landing-ai/ade-python#85
Test plan
tsc --noEmitcleanparse()→extract()with bothsaveTomodes🤖 Generated with Claude Code