Conversation
Add spec/framework.md documenting the mapping pipeline architecture, patterns, and identified inconsistencies. Fix MedicationStatement mapper to use MappingContext (was the only mapper using legacy resolveReferenceAsNumber), add drug_exposure_id assignment, and add hash mode tests. 375 tests pass (5 new). Fixes #28 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…nmapped docs for all resources
All 7 mappers now have the full "definition of done" artifacts:
- mapping/{resource}/*.md: per-element mapping specs with decisions and consensus
- tests/{resource}/*.json: declarative JSON test data (FHIR input → OMOP output)
- tests/{resource}/run.test.ts: data-driven test runners (sequential + hash mode)
- spec/*.md: updated with unmapped elements sections and validation rules
New JSON test cases: 226 (113 cases x 2 modes), total tests: 601 (up from 375).
Fixes #28
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
niquola
changed the title
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
… specs Fixes #28 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
Author
Mapping framework documented in CLAUDE.mdAdded Mapping Framework section to CLAUDE.md with: Definition of Done (4 artifacts per resource)
Also documented
Updated specs
|
…pecs Patient and Observation specs used informal "Gaps" sections while all other resource specs (Condition, Encounter, Medication, AllergyIntolerance) had formal "Unmapped FHIR Elements" tables. Now all 7 specs are consistent. Fixes #28 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Fixes #28 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Translates 35 per-element mapping specification files across all 7 resources (patient, condition, encounter, observation, medication-request, medication-statement, allergy-intolerance) to English for consistency with the rest of the project documentation. Previously only nonmapped.md files were translated. This completes the documentation language consistency effort. Fixes #28 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
… English Fixes #28 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mapping/{resource}/*.md) for all resources with decisions, consensus notes, and unmapped element listsrun.test.ts) that auto-run all JSON fixtures in both sequential and hash ID modesresolveReferenceAsNumber→MappingContext)Completeness Matrix (before → after)
Test Results
601 tests pass (up from 375), 2000 expect() calls across 15 test files.
Test plan
bun test)Fixes #28
🤖 Generated with Claude Code