test: add reason strings to bare #[ignore] attributes - #1855
Open
saitejagirada wants to merge 1 commit into
Open
saitejagirada wants to merge 1 commit into
saitejagirada wants to merge 1 commit into
Conversation
Fill every bare `#[ignore]` and `#[ignore] // comment` attribute under src/ and tests/ with a reason string in the `#[ignore = "..."]` form, matching the convention used by the other ~350 ignore attributes in the tree. In every case the reason text was already adjacent in the file (a module doc comment, a `MODEL_DIR` const, an `eprintln!` skip message, or a trailing comment). Eight files, 23 sites: - tests/deepseek_v4_real_model.rs (5) - tests/qwen38_mtp_chain_parity.rs (6) - tests/got_ocr_prompt_parity.rs (3) - tests/qwen3_omni_moe_parity.rs (1) - tests/ernie4_5_moe_vl_parity.rs (1) - src/models/diffusion_gemma/tests.rs (2) - src/downloader/tests.rs (1) - src/tokenizer/tiktoken_tests.rs (4) Closes lablup#1698
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fill every bare
#[ignore]and#[ignore] // commentattribute undersrc/andtests/with a reason string in the#[ignore = "..."]form, matching the convention used by the other ~350 ignore attributes in the tree. In every case the reason text was already adjacent in the file — a module doc comment, aMODEL_DIRconst, aneprintln!skip message, or a trailing comment.Closes #1698
Changes
Eight files, 23 sites:
tests/deepseek_v4_real_model.rstests/qwen38_mtp_chain_parity.rstests/got_ocr_prompt_parity.rstests/qwen3_omni_moe_parity.rstests/ernie4_5_moe_vl_parity.rssrc/models/diffusion_gemma/tests.rssrc/downloader/tests.rssrc/tokenizer/tiktoken_tests.rs//comment)Verification
No logic changes — purely mechanical text moves into attribute reason strings.
Acceptance Criteria (from #1698)
#[ignore]remains undersrc/andtests/