Repository navigation
Fix empty receipt-list filter messages - #205
Merged
laaielichter merged 1 commit intoNov 18, 2026
Merged
Conversation
Owner
|
Thank you, @enidchen0125, for this fix and for the careful write-up. An empty filtered Generated by Claude Code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
Fixes #204.
When receipt filters match nothing, name only the supplied
--status,--action, and--connectionfilters, in that order, instead of reporting statusNone. For example:No receipts match --action 'missing', --connection 'warehouse'.The message also names active filters when the store is empty. An empty list with no filters keepsNo receipts yet.; matching receipts and JSON'sreceipts: []shape remain unchanged.Added core and real CLI regressions for each filter, combined filters, an explicitly empty filter, an empty store, matching output, and JSON output. Updated the existing status-message assertions and documented the output in README. No changelog, package version, SQL execution, permission, or database adapter changes.
How it was tested
pytestpasses locally: 1,174 passed, 10 skipped. All 10 skips are existing live-Postgres tests requiringGULLIVER_TEST_PG_DSN; no Postgres service was available locally.ruff check .passes.Python 3.12.14, macOS arm64, isolated environment installed with
.[dev]plus Ruff. The same full pytest and Ruff checks were rerun after synchronizing the latest upstream changelog-only commit.Before the fix, baseline pytest was 1,166 passed, 10 skipped; the new targeted regression run was 7 failed, 7 passed, reproducing the wrong messages. After the fix the full suite passed as above.
git diff --checkpasses.Also ran all four CLI smoke commands from CI in a disposable synthetic DuckDB workspace:
gulliver demo smoke.duckdb --events 200000, JSON preflight for the grouped users query, the events uniqueness/not-null check, andgulliver tools --format openai; all exited 0. No customer database, cloud connection, credentials, paid API, or deployment was used.Linux, Windows, other Python versions, and live Postgres remain for repository CI; they were not run locally.
OpenAI Codex assisted with implementation, diff inspection, and the verification above under the account owner's authorization. No separate human code review is claimed.