Skip to content

Fix empty receipt-list filter messages - #205

Merged
laaielichter merged 1 commit into
laaielichter:mainfrom
enidchen0125:fix/204-receipt-filter-message
Nov 18, 2026
Merged

laaielichter merged 1 commit into
laaielichter:mainfrom
enidchen0125:fix/204-receipt-filter-message

Conversation

@enidchen0125

Copy link
Copy Markdown
Contributor

What and why

Fixes #204.

When receipt filters match nothing, name only the supplied --status, --action, and --connection filters, in that order, instead of reporting status None. For example: No receipts match --action 'missing', --connection 'warehouse'. The message also names active filters when the store is empty. An empty list with no filters keeps No receipts yet.; matching receipts and JSON's receipts: [] shape remain unchanged.

Added core and real CLI regressions for each filter, combined filters, an explicitly empty filter, an empty store, matching output, and JSON output. Updated the existing status-message assertions and documented the output in README. No changelog, package version, SQL execution, permission, or database adapter changes.

How it was tested

  • pytest passes locally: 1,174 passed, 10 skipped. All 10 skips are existing live-Postgres tests requiring GULLIVER_TEST_PG_DSN; no Postgres service was available locally.
  • ruff check . passes.
  • README updated for the changed message.

Python 3.12.14, macOS arm64, isolated environment installed with .[dev] plus Ruff. The same full pytest and Ruff checks were rerun after synchronizing the latest upstream changelog-only commit.

Before the fix, baseline pytest was 1,166 passed, 10 skipped; the new targeted regression run was 7 failed, 7 passed, reproducing the wrong messages. After the fix the full suite passed as above. git diff --check passes.

Also ran all four CLI smoke commands from CI in a disposable synthetic DuckDB workspace: gulliver demo smoke.duckdb --events 200000, JSON preflight for the grouped users query, the events uniqueness/not-null check, and gulliver tools --format openai; all exited 0. No customer database, cloud connection, credentials, paid API, or deployment was used.

Linux, Windows, other Python versions, and live Postgres remain for repository CI; they were not run locally.

OpenAI Codex assisted with implementation, diff inspection, and the verification above under the account owner's authorization. No separate human code review is claimed.

@laaielichter
laaielichter merged commit 8ac2bc3 into laaielichter:main Nov 18, 2026
14 checks passed

Copy link
Copy Markdown
Owner

Thank you, @enidchen0125, for this fix and for the careful write-up. An empty filtered receipt --list now names only the filters you used, and the new tests cover each filter, the combined and empty-store cases, and the JSON shape. It is merged, and it will appear in the next release notes, credited to you, through our credits PR.


Generated by Claude Code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

receipt --list: an empty filtered list says "No receipts with status 'None'." and should name the filters

2 participants