Repository navigation
Filter receipt listings by action and connection - #101
Conversation
laaielichter
left a comment
There was a problem hiding this comment.
Thanks @yinbowen-dc, this covers every item in the "Done when" list for #93: --action and --connection filters that combine with --status, --limit applied after filtering, an empty match returning ok with an empty list, the README line, a CHANGELOG entry and tests for each case. I merged it onto current main in a scratch checkout: ruff check . is clean and pytest -q gives 856 passed, 10 skipped.
I especially liked the test that checks the list stays summary-only (no preview leaks into the output) and that exercises both the function and main([...]).
CI for this PR is waiting for the maintainer's approval because it is your first contribution, so it may show as waiting for a while. If main moves before it lands, a quick git merge upstream/main is all that is needed; the CHANGELOG line is where a small conflict is likely.
Generated by Claude Code
|
Hi @yinbowen-dc, a quick heads-up, and thank you for your patience. The maintainer approved and merged your #99 this morning (thanks for that one too), and it added a line at the top of Could you merge the latest One thing to expect: #100 also adds a line near the top of Generated by Claude Code |
|
Good news: you no longer need to resolve the CHANGELOG conflict. We changed the rule so contributors don't edit CHANGELOG.md any more; we add your entry with credit when we merge. Easiest fix: drop your CHANGELOG.md change (or merge main and take main's version of the file) and push; the rest of the PR is unchanged. Generated by Claude Code |
laaielichter
left a comment
There was a problem hiding this comment.
Thanks @yinbowen-dc. The receipt filters work: --action and --connection combine, and removing the action filter makes 4 of the 6 new tests fail. Before this can merge:
- Merge main into the branch. The CHANGELOG.md entry conflicts. Please remove your CHANGELOG line, since the maintainer writes that entry.
- In README.md the line
gulliver receipt --list [--limit N] ...became--limit 20. Please restore--limit N; the default is a separate fact.
Generated by Claude Code
Land #101: Filter receipt listings by action and connection
|
Thank you @yinbowen-dc for the receipt filters and for the thorough tests (each filter, combinations, empty matches and limiting after the filters). It is merged with your commit kept (landed through #202, which merges your branch head and only resolves a CHANGELOG.md conflict), and the credit is in the CHANGELOG under Unreleased. I checked it on the merged code: One small thing I noticed, not a problem with your change: when a filter matches nothing, the empty-list message that landed on main in the meantime still says "No receipts with status 'None'." I will look at that separately. If you want a next one, #159 (translate the README quick start into your language) is free and labelled Generated by Claude Code |
Add exact action and connection filters to receipt listing, combined with status before applying the limit. Reuse the existing CLI connection option and retain summary-only output. Test each filter, combinations, empty matches and post-filter limiting, and update the CLI reference.
Validation:
pytest -q(856 passed, 10 skipped in 39.32s),ruff check .,git diff --check. Added regression tests fail against the original implementation and pass with this change. PostgreSQL-specific tests were not run; no external warehouse was contacted.Closes #93