feat: clone ctx - #105
Draft
rvignesh89 wants to merge 2 commits into
Draft
Conversation
Signed-off-by: Vignesh Rajasekaran <vignesh@rvignesh.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An attempt to implement #88
I'm Introducing an option to the ctx command called
clonewhich if used will clone the last context instead of trying to resolve one. If there is no previous context to switch to this command will throw an error which is not great, but making it silently fail is also possible I guess. It might be relevant for first time use.It also skips updating the session history to preserve it as otherwise you'll end up with duplicated records and
-will not work anymore. You can still pass in the namespace overrides with the-nflag if you want. So I imagine this might be used like if you want a default. Although I don't think this is very useful.I didn't look deeper into how the recursive sub-shell works because I don't use this often but if this approach makes sense I can refine that area. @sbstp what do you think of this?