feat: add s390x support to alpine-make-vm-image#1
Merged
vamsikrishna-siddu merged 1 commit intokubevirt:masterfrom Dec 10, 2025
Merged
Conversation
kubevirt-bot
added
dco-signoff: yes
dhiller
reviewed
Dec 9, 2025
dhiller
left a comment
dhiller
left a comment
There was a problem hiding this comment.
/approve
I'd ask @nekkunti and @chandramerla to review this, but basically I think this is what should be added
|
@vamsikrishna-siddu note that we don't have tide merge automation in place yet - so for now you need to merge this PR manually. |
dhiller
approved these changes
Dec 9, 2025
nekkunti
reviewed
Dec 9, 2025
nekkunti
reviewed
Dec 9, 2025
vamsikrishna-siddu
force-pushed
the
add_s390x_support
branch
from
7fb23da to
26f0c31
Compare
Implemented s390x support by enabling IPL boot on IBM Z systems. Added detailed documentation covering s390x usage, bootloader notes, and architecture-specific considerations. Signed-off-by: Vamsi Krishna Siddu <vamsikrishna.siddu@ibm.com>
vamsikrishna-siddu
force-pushed
the
add_s390x_support
branch
from
26f0c31 to
a77da70
Compare
Member
|
/lgtm |
|
As Reviewed on the PR to original/upstream repo |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR adds s390x support to alpine-make-vm-image. This is needed to build the alpine-test-tooling image used in KubeVirt E2E tests so that those tests can run on s390x.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Partially Addresses # alpinelinux/alpine-make-vm-image#43
Special notes for your reviewer:
Checklist
This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.
Release note: