Skip to content

Harden CI workflows #130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tamalsaha merged 9 commits into from
May 13, 2026
Merged

Harden CI workflows #130

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
d7be347
Use dynamic github token
tamalsaha May 11, 2026
75d469f
Harden GitHub Actions workflows
tamalsaha May 11, 2026
77cddde
Use GitHub App token for release tracker comments
tamalsaha May 13, 2026
b82c907
Apply kubedb/installer#2281: harden CI workflows
tamalsaha May 13, 2026
3f45c54
Remove Prepare git step from release-tracker.yml
tamalsaha May 13, 2026
d05e9bd
Rename LGTM App token step id to lgtm-app-token
tamalsaha May 13, 2026
0d021d1
release-tracker.yml: gate at job level with merged == true
tamalsaha May 13, 2026
f4c83de
release-tracker.yml: drop permissions block
tamalsaha May 13, 2026
b6ec3a8
release-tracker.yml: grant permission-pull-requests to LGTM App
tamalsaha May 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,13 +20,13 @@ jobs:
steps:

- name: Set up Go 1.25
uses: actions/setup-go@v5
uses: actions/setup-go@40f1582b2485089dde7abd97c1529aa768e1baff # v5.6.0
with:
go-version: '1.25'
id: go

- name: Check out code into the Go module directory
uses: actions/checkout@v4
uses: actions/checkout@34e114876b0b11c390a56381ad16ebd13914f8d5 # v4.3.1

- name: Prepare Host
run: |
Expand All @@ -48,14 +48,14 @@ jobs:
matrix:
k8s: [v1.29.14, v1.31.14, v1.33.7, v1.35.0]
steps:
- uses: actions/checkout@v4
- uses: actions/checkout@34e114876b0b11c390a56381ad16ebd13914f8d5 # v4.3.1

- name: Create Kubernetes ${{ matrix.k8s }} cluster
id: kind
uses: engineerd/setup-kind@v0.5.0
uses: helm/kind-action@ef37e7f390d99f746eb8b610417061a60e82a6cc # v1.14.0
with:
version: v0.31.0
image: kindest/node:${{ matrix.k8s }}
node_image: kindest/node:${{ matrix.k8s }}

- name: Test crds
run: |
Expand Down
32 changes: 16 additions & 16 deletions .github/workflows/release-tracker.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,30 +12,30 @@ concurrency:
jobs:
build:
runs-on: ubuntu-22.04
permissions:
contents: write

steps:
- uses: actions/checkout@v4
- uses: actions/checkout@34e114876b0b11c390a56381ad16ebd13914f8d5 # v4.3.1

- name: Prepare git
env:
GITHUB_USER: 1gtm
GITHUB_TOKEN: ${{ secrets.LGTM_GITHUB_TOKEN }}
run: |
git config --global user.name "${GITHUB_USER}"
git config --global user.email "${GITHUB_USER}@appscode.com"
git remote set-url origin https://${GITHUB_USER}:${GITHUB_TOKEN}@github.com/${GITHUB_REPOSITORY}.git

- name: Install GitHub CLI
run: |
curl -fsSL https://github.com/github/hub/raw/master/script/get | bash -s 2.14.1
sudo mv bin/hub /usr/local/bin
- name: Generate GitHub App token
id: app-token
if: |
github.event.action == 'closed' &&
github.event.pull_request.merged == true
uses: actions/create-github-app-token@bcd2ba49218906704ab6c1aa796996da409d3eb1 # v3.2.0
with:
client-id: ${{ secrets.LGTM_APP_CLIENT_ID }}
private-key: ${{ secrets.LGTM_APP_PRIVATE_KEY }}
owner: ${{ github.repository_owner }}
repositories: CHANGELOG

- name: Update release tracker
if: |
github.event.action == 'closed' &&
github.event.pull_request.merged == true
env:
GITHUB_USER: 1gtm
GITHUB_TOKEN: ${{ secrets.LGTM_GITHUB_TOKEN }}
GITHUB_USER: ${{ github.actor }}
GITHUB_TOKEN: ${{ steps.app-token.outputs.token }}
run: |
./hack/scripts/update-release-tracker.sh
17 changes: 6 additions & 11 deletions .github/workflows/update-crds.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,17 +11,12 @@ jobs:
runs-on: ubuntu-22.04
steps:
- name: Set up Go 1.25
uses: actions/setup-go@v5
uses: actions/setup-go@40f1582b2485089dde7abd97c1529aa768e1baff # v5.6.0
with:
go-version: '1.25'
id: go

- uses: actions/checkout@v4

- name: Install GitHub CLI
run: |
curl -fsSL https://github.com/github/hub/raw/master/script/get | bash -s 2.14.1
sudo mv bin/hub /usr/local/bin
- uses: actions/checkout@34e114876b0b11c390a56381ad16ebd13914f8d5 # v4.3.1

- name: Install crd-importer
run: |
Expand All @@ -31,8 +26,8 @@ jobs:

- name: Clone installer repository
env:
GITHUB_USER: 1gtm
GITHUB_TOKEN: ${{ secrets.LGTM_GITHUB_TOKEN }}
GITHUB_USER: ${{ github.actor }}
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
INSTALLER_REPOSITORY: ${{ secrets.INSTALLER_REPOSITORY }}
run: |
url="https://${GITHUB_USER}:${GITHUB_TOKEN}@${INSTALLER_REPOSITORY}.git"
Expand All @@ -44,8 +39,8 @@ jobs:

- name: Update crds
env:
GITHUB_USER: 1gtm
GITHUB_TOKEN: ${{ secrets.LGTM_GITHUB_TOKEN }}
GITHUB_USER: ${{ github.actor }}
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
INSTALLER_REPOSITORY: ${{ secrets.INSTALLER_REPOSITORY }}
run: |
export INSTALLER_ROOT=$RUNNER_WORKSPACE/$(basename $INSTALLER_REPOSITORY)
Expand Down
2 changes: 1 addition & 1 deletion hack/scripts/update-release-tracker.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,4 +69,4 @@ case $GITHUB_BASE_REF in
;;
esac

hub api "$api_url" -f body="$msg"
gh api "$api_url" -f body="$msg"
Loading