[scanner] fix: update nil-storage test for graceful nil-guard behavior

[clubanderson]

Fixes #19968

The recent nil-guard additions in #19951 changed solver behavior to handle nil storage gracefully instead of panicking. This updates TestSolveLoopWithNilStorage to verify the new graceful behavior rather than expecting a panic.

Changes

• Updated test expectation from "expect panic" to "expect NO panic"
• Changed defer function to fail if an unexpected panic occurs (instead of failing if NO panic occurs)
• Updated comments to reflect graceful nil-guard behavior
• Added clarifying comment that passing the test means no panic occurred

Testing

Verified the fix compiles with go build ./pkg/stellar/solver/

Signed-off-by: scanner scanner@hive.kubestellar.io

[kubestellar-prow]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign mikespreitzer for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[netlify]

✅ Deploy Preview for kubestellarconsole canceled.

Name	Link
🔨 Latest commit	da54cba
🔍 Latest deploy log	https://app.netlify.com/projects/kubestellarconsole/deploys/6a439158aa511b00083fb8bb

[github-actions]

🐝 Hi @clubanderson! I'm kubestellar-hive[bot], an automation bot for this repo.

Trusted users — org members and contributors with write access — can mention @kubestellar-hive in a comment to trigger repo automation.
On issues, that mention queues an automated fix attempt. On pull requests, it records extra context for existing automation.
This is not an interactive Q&A bot, so mentions should be treated as requests for automation rather than a conversation.

Automation may take a moment to start, and follow-up happens through workflow activity rather than chat replies.

[github-actions]

👋 Hey @clubanderson — thanks for opening this PR!

🤖 This project is developed exclusively using AI coding assistants.

Please do not attempt to code anything for this project manually.
All contributions should be authored using an AI coding tool such as:

• Claude Code (Opus 4.5 / 4.6) — recommended
• GitHub Copilot
• Cursor
• Other AI coding assistants

This ensures consistency in code style, architecture patterns, test coverage,
and commit quality across the entire codebase.

---

This is an automated message.

[Copilot]

Pull request overview

Updates the solver’s nil-storage regression test to reflect the current contract: SolveLoop should handle nil storage defensively (no panic) rather than crashing.

Changes:

• Updated TestSolveLoopWithNilStorage to fail only if a panic occurs (instead of expecting one).
• Refreshed test comments to describe the intended graceful nil-guard behavior.

[github-actions]

Thank you for your contribution! Your PR has been merged.

Check out what's new:

• KubeStellar Console — Live multi-cluster dashboard
• Marketplace — Community extensions
• Knowledge Base — Troubleshooting and how-tos

Stay connected: Slack #kubestellar-dev | Multi-Cluster Survey

[github-actions]

✅ Post-Merge Verification: passed

Commit: 06be50b35f4fbccea2c7ecea9e9a3537d67f0cfd
Specs run: smoke.spec.ts
Report: https://github.com/kubestellar/console/actions/runs/28438039237

[github-actions]

Post-merge build verification passed ✅

Both Go and frontend builds compiled successfully against merge commit 06be50b35f4fbccea2c7ecea9e9a3537d67f0cfd.