[quality] fix: solver test emoji mismatch breaking go test on all PRs (P0)

[clubanderson]

Test Fix (P0)

Aligns solver_coverage_test.go emoji assertions with the production code in solver.go.

Root cause: solver.go was updated to use \u2746 (❆ six-pointed star) for resolved notifications, but the test file still expected \u2726 (✦ four-pointed star). This causes TestTerminateResolved and TestTerminateAllStatusTypes/resolved_status to fail, blocking go test ./... on all open PRs.

Fix: Update both test assertions (lines 136 and 456) to match the production emoji \u2746.

---

Filed by quality agent (hold-gated mode). Human review required.

[netlify]

✅ Deploy Preview for kubestellarconsole canceled.

Name	Link
🔨 Latest commit	9f8aaf0
🔍 Latest deploy log	https://app.netlify.com/projects/kubestellarconsole/deploys/6a430a6345152d0008afe60f

[kubestellar-prow]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign mikespreitzer for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[github-actions]

👋 Hey @clubanderson — thanks for opening this PR!

🤖 This project is developed exclusively using AI coding assistants.

Please do not attempt to code anything for this project manually.
All contributions should be authored using an AI coding tool such as:

• Claude Code (Opus 4.5 / 4.6) — recommended
• GitHub Copilot
• Cursor
• Other AI coding assistants

This ensures consistency in code style, architecture patterns, test coverage,
and commit quality across the entire codebase.

---

This is an automated message.

[github-actions]

🐝 Hi @clubanderson! I'm kubestellar-hive[bot], an automation bot for this repo.

Trusted users — org members and contributors with write access — can mention @kubestellar-hive in a comment to trigger repo automation.
On issues, that mention queues an automated fix attempt. On pull requests, it records extra context for existing automation.
This is not an interactive Q&A bot, so mentions should be treated as requests for automation rather than a conversation.

Automation may take a moment to start, and follow-up happens through workflow activity rather than chat replies.

[Copilot]

Pull request overview

Fixes failing solver termination tests by aligning the “resolved” notification title emoji assertion with the production implementation in terminate().

Changes:

• Update TestTerminateResolved expected notification title to use \u2746 (❆) instead of \u2726 (✦).
• Update the “resolved status” table case in TestTerminateAllStatusTypes to expect the same \u2746 (❆) title string.

[clubanderson]

Closing — superseded by #19951 which includes both the emoji test fix and nil-safety guards for pkg/agent/registry.go and pkg/stellar/solver/solver.go.