[quality] pkg/agent: extended registry + provider_prompts tests (17 cases) by clubanderson · Pull Request #19921 · kubestellar/console

clubanderson · 2026-06-29T16:28:59Z

Test Improvement

Adds 15+ test cases covering previously untested logic paths in pkg/agent:

`registry_extended_test.go` (11 test functions)

Test	What's verified
`TestRegistry_NilReceiver`	All public methods return errors / don't panic on nil `*Registry`
`TestRegistry_RemoveSelectedAgent`	Session cleanup removes from both internal maps, falls back to default
`TestRegistry_PromoteExecutingDefault`	copilot-cli (suggest-only) → tool-capable agent promotion
`TestRegistry_PromoteExecutingDefault_NoChange`	Non-suggest-only default is not changed
`TestRegistry_PromoteExecutingDefault_NoBetterOption`	copilot-cli retained when no tool-capable agents exist
`TestRegistry_SetSelectedAgent_LRUEviction`	Batch eviction fires at 10000 cap, removes ~5% oldest
`TestRegistry_ConcurrentAccess`	100 goroutines exercising all read/write paths (race detector)
`TestRegistry_GetDefault_NotFound`	Error when defaultAgent name not in providers map
`TestRegistry_SetDefault_NilProvider`	Error when provider entry is nil
`TestRegistry_HasAvailableProviders_WithNilEntry`	nil entries don't count as available

`provider_prompts_test.go` (6 test functions)

Test	What's verified
`TestOSCommandHint_NotEmpty`	Returns non-empty string
`TestOSCommandHint_ContainsShellReference`	Platform-appropriate shell hint (bash/PowerShell)
`TestOSContext_MatchesRuntime`	Contains runtime.GOOS
`TestDefaultSystemPrompt_NotEmpty`	System prompt is populated
`TestChatOnlySystemPrompt_NotEmpty`	Chat-only prompt is populated
`TestChatOnlySystemPrompt_DiffersFromDefault`	Two prompts are distinct

Partially addresses #19907

Filed by quality agent (ACMM L4/L6 — full mode)

Adds 15+ test cases covering previously untested paths in pkg/agent: Registry (registry_extended_test.go): - Nil receiver safety for all public methods - RemoveSelectedAgent cleanup verification - promoteExecutingDefault (3 scenarios: promotion, no-change, no-better-option) - LRU eviction when selectedAgent map exceeds 10000 cap - Concurrent access safety (race detector coverage) - GetDefault with missing provider in map - SetDefault with nil provider entry - HasAvailableProviders with nil map entry Provider prompts (provider_prompts_test.go): - OSCommandHint returns non-empty, contains shell reference - OSContext matches runtime.GOOS - DefaultSystemPrompt and ChatOnlySystemPrompt non-empty and differ Partially addresses #19907. Signed-off-by: quality-agent <quality@kubestellar.io>

kubestellar-prow · 2026-06-29T16:29:03Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign eeshaansa for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

netlify · 2026-06-29T16:29:05Z

✅ Deploy Preview for kubestellarconsole ready!

Name	Link
🔨 Latest commit	`dd9462c`
🔍 Latest deploy log	https://app.netlify.com/projects/kubestellarconsole/deploys/6a42b0c0a2789f00080eb9c4
😎 Deploy Preview	https://deploy-preview-19921.console-deploy-preview.kubestellar.io
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

github-actions · 2026-06-29T16:29:07Z

🐝 Hi @clubanderson! I'm kubestellar-hive[bot], an automation bot for this repo.

Trusted users — org members and contributors with write access — can mention @kubestellar-hive in a comment to trigger repo automation.
On issues, that mention queues an automated fix attempt. On pull requests, it records extra context for existing automation.
This is not an interactive Q&A bot, so mentions should be treated as requests for automation rather than a conversation.

Automation may take a moment to start, and follow-up happens through workflow activity rather than chat replies.

github-actions · 2026-06-29T16:29:09Z

👋 Hey @clubanderson — thanks for opening this PR!

🤖 This project is developed exclusively using AI coding assistants.

Please do not attempt to code anything for this project manually.
All contributions should be authored using an AI coding tool such as:

Claude Code (Opus 4.5 / 4.6) — recommended

GitHub Copilot

Cursor

Other AI coding assistants

This ensures consistency in code style, architecture patterns, test coverage,
and commit quality across the entire codebase.

This is an automated message.

Copilot

Pull request overview

This PR improves pkg/agent quality by adding targeted Go tests that exercise previously untested/edge logic in the agent registry and provider prompt wrappers, contributing toward the coverage goals in #19907.

Changes:

Add extended registry tests covering nil receiver behavior, session cleanup, default-agent promotion, LRU eviction behavior, and concurrent access.
Add tests for pkg/agent prompt wrapper exports (OSCommandHint, OSContext, DefaultSystemPrompt, ChatOnlySystemPrompt).

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File	Description
pkg/agent/registry_extended_test.go	Adds broad registry behavior tests (nil-safety, default promotion, eviction, concurrency).
pkg/agent/provider_prompts_test.go	Adds tests validating prompt wrapper functions and exported prompt vars are populated and distinct.

+	for i := 0; i < 10000; i++ {
+		sid := fmt.Sprintf("old-session-%d", i)
+		r.selectedAgent[sid] = "a"
+		// All old sessions have old timestamps
+		r.selectedAgentLRU[sid] = time.Now().Add(-time.Hour)
+	}


clubanderson · 2026-06-29T17:00:01Z

Quality review of test code:

✅ Good test patterns:

Nil receiver safety tests catch panic risks
LRU eviction test validates the 10K cap with 5% eviction
Concurrent access test with race detector coverage
Edge cases: nil provider in map, phantom default name

⚠️ CI failure is from the fasthttp Host header issue (same as #19909), not from these tests themselves. Once #19925 lands, this PR should pass CI — rebase and re-run.

⚠️ Minor concern: provider_prompts_test.go tests are smoke-level (non-empty, differs). Consider adding tests for prompt content structure (e.g., system prompts contain key directives) in a follow-up.

This PR partially addresses #19907 by adding tests for registry.go edge cases and provider_prompts.go. The remaining untested files from that issue (provider.go, server_routes.go, shell.go, compat shims) still need coverage.

…ation Signed-off-by: clubanderson <clubanderson@users.noreply.github.com>

github-actions · 2026-06-29T18:20:49Z

Thank you for your contribution! Your PR has been merged.

Check out what's new:

KubeStellar Console — Live multi-cluster dashboard
Marketplace — Community extensions
Knowledge Base — Troubleshooting and how-tos

Stay connected: Slack #kubestellar-dev | Multi-Cluster Survey

github-actions · 2026-06-29T18:27:08Z

Post-merge build verification passed ✅

Both Go and frontend builds compiled successfully against merge commit d8838dc2726ab1706b002785c611947d071f5bf5.

github-actions · 2026-06-29T18:27:19Z

✅ Post-Merge Verification: passed

Commit: d8838dc2726ab1706b002785c611947d071f5bf5
Specs run: smoke.spec.ts
Report: https://github.com/kubestellar/console/actions/runs/28393542411

Copilot AI review requested due to automatic review settings June 29, 2026 16:29

kubestellar-prow Bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label Jun 29, 2026

kubestellar-prow Bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jun 29, 2026

github-actions Bot added the tier/1-lightweight label Jun 29, 2026

clubanderson mentioned this pull request Jun 29, 2026

[quality] pkg/agent at 48% coverage — 12 source files lack dedicated tests #19907

Closed

Copilot started reviewing on behalf of clubanderson June 29, 2026 16:29 View session

Copilot AI reviewed Jun 29, 2026

View reviewed changes

Comment thread pkg/agent/registry_extended_test.go

Comment on lines +169 to +174

for i := 0; i < 10000; i++ {

sid := fmt.Sprintf("old-session-%d", i)

r.selectedAgent[sid] = "a"

// All old sessions have old timestamps

r.selectedAgentLRU[sid] = time.Now().Add(-time.Hour)

}

clubanderson mentioned this pull request Jun 29, 2026

[scanner] fix: add unit tests for pkg/agent to improve coverage #19920

Closed

Merge branch 'main' into quality/agent-registry-coverage

39ac874

kubestellar-hive Bot mentioned this pull request Jun 29, 2026

🐝 Hive Advisory Report #19517

Open

clubanderson added 2 commits June 29, 2026 13:39

fix: rename mockToolProvider to mockRegToolProvider to avoid redeclar…

3ef5982

…ation Signed-off-by: clubanderson <clubanderson@users.noreply.github.com>

Merge branch 'main' into quality/agent-registry-coverage

dd9462c

clubanderson merged commit d8838dc into main Jun 29, 2026
25 of 31 checks passed

kubestellar-prow Bot deleted the quality/agent-registry-coverage branch June 29, 2026 18:20

clubanderson mentioned this pull request Jun 29, 2026

[quality] add unit tests for 6 untested compat/delegation files in pkg/agent #19937

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[quality] pkg/agent: extended registry + provider_prompts tests (17 cases)#19921

[quality] pkg/agent: extended registry + provider_prompts tests (17 cases)#19921
clubanderson merged 4 commits into
mainfrom
quality/agent-registry-coverage

clubanderson commented Jun 29, 2026

Uh oh!

kubestellar-prow Bot commented Jun 29, 2026

Uh oh!

netlify Bot commented Jun 29, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Jun 29, 2026

Uh oh!

github-actions Bot commented Jun 29, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

clubanderson commented Jun 29, 2026

Uh oh!

Uh oh!

github-actions Bot commented Jun 29, 2026

Uh oh!

github-actions Bot commented Jun 29, 2026

Uh oh!

github-actions Bot commented Jun 29, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

clubanderson commented Jun 29, 2026

Test Improvement

registry_extended_test.go (11 test functions)

provider_prompts_test.go (6 test functions)

Uh oh!

kubestellar-prow Bot commented Jun 29, 2026

Uh oh!

netlify Bot commented Jun 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for kubestellarconsole ready!

Uh oh!

github-actions Bot commented Jun 29, 2026

Uh oh!

github-actions Bot commented Jun 29, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

clubanderson commented Jun 29, 2026

Uh oh!

Uh oh!

github-actions Bot commented Jun 29, 2026

Uh oh!

github-actions Bot commented Jun 29, 2026

Uh oh!

github-actions Bot commented Jun 29, 2026

✅ Post-Merge Verification: passed

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

`registry_extended_test.go` (11 test functions)

`provider_prompts_test.go` (6 test functions)

netlify Bot commented Jun 29, 2026 •

edited

Loading