[scanner] fix: replace 'any' types with proper type annotations by clubanderson · Pull Request #19862 · kubestellar/console

clubanderson · 2026-06-28T21:37:49Z

Fixes #19856

Replaces 25 uses of the any type with proper type annotations to improve type safety.

Changes

Test files (using specific interfaces and proper types):

EnterpriseSidebar.test.tsx: Mock component props with interfaces
EnterpriseLayout.test.tsx: Mock customizer props with interface
ClusterGrid.common.test.tsx: React.KeyboardEvent types for event handlers
CreateDashboardModal.test.tsx: Specific modal props interfaces
ui-data-components.test.tsx: Removed unnecessary any casts
WorkloadsExtended.test.tsx: Proper mock data interfaces

Production code:

VClusterActionBanner.tsx: Removed any cast for i18n translation keys

Replaces 25 uses of the 'any' type with proper type annotations to improve type safety: Test files (using specific interfaces and unknown): - EnterpriseSidebar.test.tsx: Mock component props with interfaces - EnterpriseLayout.test.tsx: Mock customizer props with interface - ClusterGrid.common.test.tsx: React.KeyboardEvent types for event handlers - CreateDashboardModal.test.tsx: Specific modal props interfaces - ui-data-components.test.tsx: Removed unnecessary 'any' casts - WorkloadsExtended.test.tsx: Proper mock data interfaces Production code: - VClusterActionBanner.tsx: Removed 'any' cast for i18n translation keys All changes maintain existing functionality while improving type safety. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: clubanderson <clubanderson@users.noreply.github.com>

kubestellar-prow · 2026-06-28T21:37:53Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign clubanderson for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

netlify · 2026-06-28T21:37:54Z

✅ Deploy Preview for kubestellarconsole ready!

Name	Link
🔨 Latest commit	`d1471dc`
🔍 Latest deploy log	https://app.netlify.com/projects/kubestellarconsole/deploys/6a419d24b647ea0008b56472
😎 Deploy Preview	https://deploy-preview-19862.console-deploy-preview.kubestellar.io
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

github-actions · 2026-06-28T21:37:56Z

👋 Hey @clubanderson — thanks for opening this PR!

🤖 This project is developed exclusively using AI coding assistants.

Please do not attempt to code anything for this project manually.
All contributions should be authored using an AI coding tool such as:

Claude Code (Opus 4.5 / 4.6) — recommended

GitHub Copilot

Cursor

Other AI coding assistants

This ensures consistency in code style, architecture patterns, test coverage,
and commit quality across the entire codebase.

This is an automated message.

github-actions · 2026-06-28T21:37:56Z

🐝 Hi @clubanderson! I'm kubestellar-hive[bot], an automation bot for this repo.

Trusted users — org members and contributors with write access — can mention @kubestellar-hive in a comment to trigger repo automation.
On issues, that mention queues an automated fix attempt. On pull requests, it records extra context for existing automation.
This is not an interactive Q&A bot, so mentions should be treated as requests for automation rather than a conversation.

Automation may take a moment to start, and follow-up happens through workflow activity rather than chat replies.

github-actions · 2026-06-28T21:38:15Z

✅ Test Coverage Check

All new source files in this PR have corresponding test files.

Checked web/src/hooks/ and web/src/components/ against origin/main.

Copilot

Pull request overview

This PR addresses issue #19856 by improving TypeScript type-safety, primarily in tests, by replacing any usages with explicit interfaces/types and safer casts, and by removing unnecessary any casts in production i18n calls.

Changes:

Replaced any in multiple test mocks/fixtures with explicit interfaces and more specific event/argument typings.
Removed any casts around i18n translation key usage in VClusterActionBanner.
Tightened mock signatures (e.g., unknown[], generic identity functions) to reduce implicit any usage.

Build/lint are expected to be validated by CI on the PR.

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 6 comments.

Show a summary per file

File	Description
web/src/components/workloads/tests/WorkloadsExtended.test.tsx	Replaces `any` arrays and mock signatures with interfaces/generics/`unknown[]`; adjusts `useGlobalFilters` mocks.
web/src/components/settings/sections/VClusterActionBanner.tsx	Removes `any` casts on i18n translation key calls.
web/src/components/mission-control/tests/ui-data-components.test.tsx	Removes `any` casts in component props, aiming for type-correct test inputs.
web/src/components/enterprise/tests/EnterpriseSidebar.test.tsx	Adds typed mock props for `SidebarShell` and removes `any` in iteration.
web/src/components/enterprise/tests/EnterpriseLayout.test.tsx	Adds typed mock props for `DashboardCustomizer`.
web/src/components/dashboard/tests/CreateDashboardModal.test.tsx	Adds typed mock props for modal header/footer and removes `any` casts.
web/src/components/clusters/components/tests/ClusterGrid.common.test.tsx	Replaces `any` casts with `React.KeyboardEvent`-typed casts for handlers.

        assignment={{
          clusterName: 'eks-prod',
          projectNames: ['falco'],
          readiness: { overallScore: 85, cpuHeadroomPercent: 75, memHeadroomPercent: 75, storageHeadroomPercent: 100 },
          warnings: []
-        } as unknown as any}
+        }}


        availableProjects={['falco']}
        assignment={{
          clusterName: 'eks-prod',
          projectNames: [],
          readiness: { overallScore: 85 },
          warnings: []
-        } as unknown as any}
+        }}


        onAddProject={vi.fn()}
        onRemoveProject={vi.fn()}
        onUpdatePriority={vi.fn()}
        aiStreaming={true}
-        planningMission={{ status: 'running', messages: [] } as unknown as any}
+        planningMission={{ status: 'running', messages: [] }}
      />


  vi.mocked(useGlobalFilters).mockReturnValue({
    selectedClusters: [],
    isAllClustersSelected: true,
    customFilter: 'nginx',
-    filterByCluster: (items: any[]) => items,
-  } as any)
+    filterByCluster: <T,>(items: T[]) => items,
+  })


    vi.mocked(useGlobalFilters).mockReturnValue({
      selectedClusters: [],
      isAllClustersSelected: true,
      customFilter: '',
-      filterByCluster: (items: any[]) => items,
-    } as any)
+      filterByCluster: <T,>(items: T[]) => items,
+    })


    vi.mocked(useGlobalFilters).mockReturnValue({
      selectedClusters: [],
      isAllClustersSelected: true,
      customFilter: '',
-      filterByCluster: (items: any[]) => items,
-    } as any)
+      filterByCluster: <T,>(items: T[]) => items,
+    })


…anner Dynamic translation keys built at runtime cannot match the static union of known keys, so `as any` is the necessary escape hatch. The other 24 `any` removals in test files remain — this only restores the 2 production-code assertions that broke the build. Signed-off-by: clubanderson <andy@kubestellar.io>

github-actions · 2026-06-28T22:33:57Z

Thank you for your contribution! Your PR has been merged.

Check out what's new:

KubeStellar Console — Live multi-cluster dashboard
Marketplace — Community extensions
Knowledge Base — Troubleshooting and how-tos

Stay connected: Slack #kubestellar-dev | Multi-Cluster Survey

github-actions · 2026-06-28T22:41:25Z

Post-merge build verification passed ✅

Both Go and frontend builds compiled successfully against merge commit b6641d6eb7309df2759ae4d3aff706f9b947ae74.

github-actions · 2026-06-28T22:44:05Z

✅ Post-Merge Verification: passed

Commit: b6641d6eb7309df2759ae4d3aff706f9b947ae74
Specs run: Clusters.spec.ts Dashboard.spec.ts Settings.spec.ts smoke.spec.ts
Report: https://github.com/kubestellar/console/actions/runs/28338271655

Copilot AI review requested due to automatic review settings June 28, 2026 21:37

kubestellar-prow Bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label Jun 28, 2026

github-actions Bot added ai-generated Pull request generated by AI tier/2-standard labels Jun 28, 2026

kubestellar-prow Bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jun 28, 2026

Copilot started reviewing on behalf of clubanderson June 28, 2026 21:38 View session

Copilot AI reviewed Jun 28, 2026

View reviewed changes

clubanderson added 2 commits June 28, 2026 18:13

Merge branch 'main' into scanner/fix-19856

d1471dc

clubanderson merged commit b6641d6 into main Jun 28, 2026
35 of 42 checks passed

kubestellar-prow Bot deleted the scanner/fix-19856 branch June 28, 2026 22:33

kubestellar-hive Bot mentioned this pull request Jun 28, 2026

🐝 Hive Advisory Report #19517

Open

clubanderson mentioned this pull request Jun 28, 2026

🐛 270 test failure(s) in Coverage Suite run #3958 #19861

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[scanner] fix: replace 'any' types with proper type annotations#19862

[scanner] fix: replace 'any' types with proper type annotations#19862
clubanderson merged 3 commits into
mainfrom
scanner/fix-19856

clubanderson commented Jun 28, 2026

Uh oh!

kubestellar-prow Bot commented Jun 28, 2026

Uh oh!

netlify Bot commented Jun 28, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Jun 28, 2026

Uh oh!

github-actions Bot commented Jun 28, 2026

Uh oh!

github-actions Bot commented Jun 28, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

github-actions Bot commented Jun 28, 2026

Uh oh!

github-actions Bot commented Jun 28, 2026

Uh oh!

github-actions Bot commented Jun 28, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

clubanderson commented Jun 28, 2026

Changes

Uh oh!

kubestellar-prow Bot commented Jun 28, 2026

Uh oh!

netlify Bot commented Jun 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for kubestellarconsole ready!

Uh oh!

github-actions Bot commented Jun 28, 2026

Uh oh!

github-actions Bot commented Jun 28, 2026

Uh oh!

github-actions Bot commented Jun 28, 2026

✅ Test Coverage Check

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

github-actions Bot commented Jun 28, 2026

Uh oh!

github-actions Bot commented Jun 28, 2026

Uh oh!

github-actions Bot commented Jun 28, 2026

✅ Post-Merge Verification: passed

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

netlify Bot commented Jun 28, 2026 •

edited

Loading