Repository navigation
Conversation
Signed-off-by: Jeff Spahr <spahrj@gmail.com>
Contributor Report for @jeffspahr
|
Collaborator
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: zazulam The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Jeff Spahr <spahrj@gmail.com>
|
New changes are detected. LGTM label has been removed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
release-2.18image-release dispatcher calls reusable build and manifest workflows without explicitGITHUB_TOKENgrants. Once the repository default becomes read-only, those callees cannot elevate the caller's token, which would break image publication.Change
contents: read,packages: write,attestations: write, andid-token: write; grant manifest promotion onlycontents: readandpackages: write.secrets: inheritpass-through. Both callees use the automatically availableGITHUB_TOKEN.imagetoolsargument, while clearing the pre-existing whitespace and ShellCheck failures exposed by this PR.The 13-image legacy inventory, architecture exclusions, release inputs, and dry-run/no-push behavior are unchanged. Manifest publication still passes each validated digest as its own source argument.
Validation
git diff --checkpasses.latesttags, invalid filenames are skipped, andset_latest=falseomits the second invocation. No image was published.Rollout
Follow-up to #15006, alongside the merged
release-2.17caller backport #15027 and the separate 2.17 manifest cleanup #15030. Do not lower repository token defaults until the workflow backports merge and representative CI and release dry runs pass. This PR does not change repository settings or publish images/packages.Checklist: