Repository navigation
Conversation
|
Skipping CI for Draft Pull Request. |
Contributor Report for @jeffspahr
|
48 of 53 tasks
Signed-off-by: Jeff Spahr <spahrj@gmail.com>
Signed-off-by: Jeff Spahr <spahrj@gmail.com>
Signed-off-by: Jeff Spahr <spahrj@gmail.com>
Signed-off-by: Jeff Spahr <spahrj@gmail.com>
Signed-off-by: Jeff Spahr <spahrj@gmail.com>
Signed-off-by: Jeff Spahr <spahrj@gmail.com>
Signed-off-by: Jeff Spahr <spahrj@gmail.com>
Signed-off-by: Jeff Spahr <spahrj@gmail.com>
Signed-off-by: Jeff Spahr <spahrj@gmail.com>
Open
22 tasks
Signed-off-by: Jeff Spahr <spahrj@gmail.com>
Signed-off-by: Jeff Spahr <spahrj@gmail.com>
Signed-off-by: Jeff Spahr <spahrj@gmail.com>
Signed-off-by: Jeff Spahr <spahrj@gmail.com>
Signed-off-by: Jeff Spahr <spahrj@gmail.com>
Signed-off-by: Jeff Spahr <spahrj@gmail.com>
Signed-off-by: Jeff Spahr <spahrj@gmail.com>
Signed-off-by: Jeff Spahr <spahrj@gmail.com>
This was referenced Oct 20, 2026
Signed-off-by: Jeff Spahr <spahrj@gmail.com>
Signed-off-by: Jeff Spahr <spahrj@gmail.com>
Signed-off-by: Jeff Spahr <spahrj@gmail.com>
Signed-off-by: Jeff Spahr <spahrj@gmail.com>
Signed-off-by: Jeff Spahr <spahrj@gmail.com>
Signed-off-by: Jeff Spahr <spahrj@gmail.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Core Pipelines workflows use inconsistent navigation, page layouts and interaction patterns, making common run, pipeline and experiment tasks harder to discover and use. The UI needs a coherent, accessible design while preserving API contracts, ownership boundaries and existing workflow behavior.
Modernizes the Pipelines UI across the main workflows with a shared light/dark design system while retaining API and functional contracts. Part of #14572; no KEP is required.
What changes
Page, contents use role names such asForm,ViewandDialog, and context wrappers useWithContext; sole presentation implementations no longer carryModern,EnhancedorV2labels. API version labels and feature-flagged query page alternatives remain explicit.The workflow contracts distinguish preserved functionality from deliberate major-release UX improvements. Coverage includes all 19 toolbar action keys through the real factory and renderer, encoded resource links, selectable rows, URL-owned inspection history, status semantics, scoped search races, native form submission and duplicate-mutation protection. JupyterHub navigation was already disabled by #1046. Runs status filtering, global counts and the 48-hour failure summary remain deferred.
Scope and qualification
Production-browser regression suites and the required Linux Chromium lane remain here. Broad browser/device qualification, historical performance builds and Kubernetes deployment/rollback tooling are extracted into draft #14757, which lands after this PR. Its weekly/manual runs remain observational until #14754 and #14755 establish reliability and maintainers separately approve any promotion.
Generated evidence is excluded from the source tree. Kubeflow-owned archives and hashes preserve prior measurements, screenshots and manifests; all 271 remaining generated files were verified against the October 8 archive before removal. Executable fixtures remain with their tests. Both original archives and browsable snapshots are retained on the dedicated Kubeflow-owned
codex/ui-modernization-evidencebranch, pinned tod9aed93d6184be1f65d36066b40eb92028a2aa25. Original archive hashes and all 312 indexed files were verified from a fresh upstream clone. Routine results belong in Actions artifacts, with project-owned storage for retained evidence.Demo
Watch the 2:18 legacy/modern walkthrough with Tom narration · Captions · Transcript and recording provenance
Includes Timeline, export/import, the compact footer and UI-library changes. It compares legacy
b018d7edwith moderna9561f1a0; it predates final review fixes and is a workflow demonstration, not a speed benchmark.Verification
9316e66c7, preserving inline sub-DAG rendering (feat(frontend): render sub-DAGs as expanded inline groups #14751) and flush graph layout (fix(frontend): make graph canvases flush with tabs #14878). Independent merge-tree comparison confirms all non-frontend files match the combined inputs; graph integration received a separate review.Before merge
Latest conflict resolution
Rebased onto master
a9ccfc740. Integrated the newly merged System Logs tab with the modernized inspection tabs and error dialog, retaining driver-log polling, refresh recovery, and task/URI/namespace isolation. The final rebased tree exactly matches an independently resolved merge. All 49 RuntimeNodeDetails tests, targeted ESLint, TypeScript, formatting, and whitespace checks pass. Earlier graph and browser evidence above remains revision-specific; fresh hosted CI must validate head203619c37.Latest CI repair
The deep-linked iteration regression now uses a minimal valid loop body rather than repeating unrelated evaluation and artifact subgraphs across eleven iterations. The complete original navigation sequence and assertions remain intact: reveal iteration 10, inspect its task details, close the panel, and inspect the enclosing loop while retaining the root graph. No production behavior or test timeout changed. The final regression passes with V8 coverage under Node 24.14.0; TypeScript, configured UI lint, formatting, and whitespace checks pass. Required hosted CI must validate the new head.