Skip to content

[KCM-6031] FinOps Agent release automation - #210

Merged
thomasvn merged 11 commits into
developfrom
thomasn/auto-release
Aug 11, 2026
Merged

[KCM-6031] FinOps Agent release automation#210
thomasvn merged 11 commits into
developfrom
thomasn/auto-release

Conversation

@thomasvn

@thomasvn thomasvn commented Jul 22, 2026

Copy link
Copy Markdown
Member
  1. Build the agent image
  2. Update & publish the finops-agent chart
  3. Update the Kubecost helm chart to point to the new finops-agent subchart

Addresses KCM-6031

@peatey

peatey commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

hey @thomasvn are we still looking to drop this in?

@thomasvn

thomasvn commented Aug 5, 2026

Copy link
Copy Markdown
Member Author

@peatey Still need to validate that it works. Also, the current implementation uses a PAT, which we may want to move away from. Update it to use Github Apps instead.

@thomasvn
thomasvn marked this pull request as ready for review August 7, 2026 20:19
@thomasvn thomasvn added the bob_review_requested Managed by Bob Review GitHub App label Aug 7, 2026
@bob-review-bot bob-review-bot Bot added the bob_review_in_progress Managed by Bob Review GitHub App label Aug 7, 2026

@bob-review-bot bob-review-bot Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This workflow automates the FinOps Agent release across three repositories with appropriate security controls (scoped GitHub App tokens, tag collision checks, dry-run mode). The orchestration logic is sound with proper polling and error handling for cross-repo dependencies. Two medium-severity issues warrant attention: hardcoded workflow names create fragile cross-repo dependencies that will timeout silently if renamed, and the dry-run mode skips Chart.lock regeneration, creating a validation gap for dependency resolution.

Overall: Looks good with minor comments.

No CI evidence was available for this review (Release automation workflow; no test coverage expected for GHA workflows themselves.).

A couple of observations for the reviewer:

  • The workflow's dry-run mode is well-designed: it uses git push --dry-run to validate auth and ref updates without landing changes, and skips side-effect-dependent steps. This is a good pattern for testing release automation.
  • The polling logic for cross-repo workflow starts uses a 2-minute timeout with 5-second intervals, which is reasonable for GitHub Actions dispatch latency. The ${RUN_ID:?...} bash expansion ensures the script fails loudly if the workflow never appears.
  • The workflow correctly uses needs: dependencies to enforce the release sequence (tag → build → chart → kubecost), preventing partial releases if an earlier step fails.

Posting this with high confidence. Both findings confirmed through direct file inspection; workflow structure and cross-repo contract are well-understood.


Reviewed by the Redline bot. This is an automated first-pass review;
a human reviewer is still required.

Comment thread .github/workflows/release.yaml
Comment thread .github/workflows/release.yaml
@bob-review-bot bob-review-bot Bot added bob_review_completed and removed bob_review_in_progress Managed by Bob Review GitHub App labels Aug 7, 2026
@thomasvn
thomasvn enabled auto-merge August 10, 2026 15:56
@thomasvn
thomasvn added this pull request to the merge queue Aug 11, 2026
Merged via the queue into develop with commit 1787a48 Aug 11, 2026
13 checks passed
@thomasvn
thomasvn deleted the thomasn/auto-release branch August 11, 2026 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants