docs: clarify custom predictor protocol settings - #709
Open
euisuh wants to merge 2 commits into
Open
Conversation
✅ Deploy Preview for elastic-nobel-0aef7a ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Explain how REST v1/v2 routes are selected for custom predictors and clarify that predictor protocol args are for transformer-to-predictor calls. Co-authored-by: Hermes Agent <noreply@nousresearch.com> Signed-off-by: euisuh <euisuh.jeong@gmail.com>
euisuh
force-pushed
the
docs/custom-model-protocol-3009
branch
from
July 24, 2026 01:05
45b4023 to
a34e89c
Compare
Avoid overstating the scope of predictor protocol arguments while keeping the route-selection clarification. Co-authored-by: Hermes Agent <noreply@nousresearch.com> Signed-off-by: euisuh <euisuh.jeong@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses kserve/kserve#3009
Proposed Changes
ModelServerregisters both REST v1 and REST v2 routes.--predictor_protocoland deprecated--protocolare for transformer-to-predictor calls, not for selecting exposed custom predictor routes.PROTOCOLenvironment variable guidance from the custom predictor docs.Validation
git diff --checkpassed.RESTServerregisters both v1 and v2 endpoints.--protocolis a deprecated alias for--predictor_protocol./v2/models/{model_name}/infer.PROTOCOLbullet is absent.Notes:
npm run typecheckcurrently fails on existingsrc/components/QuickInstallCommand.tsxReact typing errors unrelated to this Markdown change.npm run buildcurrently fails in the local environment on Mermaid dependency resolution (@mermaid-js/parser), also unrelated to this Markdown change.AI assistance was used to prepare this documentation change; I reviewed the changed lines and verified them against the KServe source.