fix(create_ssl_context)!: remove crlfile field

kstreams/utils.py

@@ -5,7 +5,7 @@
 import ssl
 import sys
 from tempfile import NamedTemporaryFile
-from typing import Any, Optional, Type, Union
+from typing import Optional, Type, Union
 
 from aiokafka.helpers import create_ssl_context as aiokafka_create_ssl_context
 
@@ -75,13 +75,16 @@ def create_ssl_context(
     certfile: Optional[str] = None,
     keyfile: Optional[str] = None,
     password: Optional[str] = None,
-    crlfile: Any = None,
 ):
     """Wrapper of [aiokafka.helpers.create_ssl_context](
         https://aiokafka.readthedocs.io/en/stable/api.html#helpers
     )
     with typehints.
 
+    Note:
+        Legacy function, we leave it to not depend directly on aiokafka,
+        but aiokafka now has typehints.
+
     Arguments:
         cafile: Certificate Authority file path containing certificates
             used to sign broker certificates
@@ -104,7 +107,6 @@ def create_ssl_context(
         certfile=certfile,
         keyfile=keyfile,
         password=password,
-        crlfile=crlfile,
     )
 
 

scripts/bench-compare

@@ -1,4 +1,4 @@
-#!/bin/bash
+#!/usr/bin/env bash
 # This script runs pytest benchmarks to compare benchmark results.
 #
 # The script compares the latest benchmark with the current code.

scripts/bench-current

@@ -1,4 +1,4 @@
-#!/bin/bash -e
+#!/usr/bin/env bash
 # This script runs benchmark tests using pytest and saves the results.
 #
 # By saving this information, way we can keep track of the regressions in performance.
@@ -7,6 +7,7 @@
 # Usage:
 # 1. Run this script from the terminal: ./bench-current
 # 2. The benchmark results will be saved in the `.benchmarks` folder.
+set -e
 
 export PREFIX=""
 if [ -d '.venv' ] ; then

scripts/cluster/bash

@@ -1,4 +1,5 @@
-#!/bin/sh -e
+#!/usr/bin/env sh
+set -e
 
 service="${1:-kafka}"
 docker-compose run --user="$(id -u)" "${service}" bash

scripts/cluster/events/read

@@ -1,11 +1,12 @@
-#!/bin/sh -e
+#!/usr/bin/env sh
 #
 # Read messages from the given kafka topic
 #
 # Usage:
 #
 # ./scripts/cluster/events/read  # default: local--hello-world
 # ./scripts/cluster/events/read "example-topic"
+set -e
 
 topic_name="${1:-local--hello-world}"
 

scripts/cluster/events/send

@@ -1,11 +1,12 @@
-#!/bin/sh -e
+#!/usr/bin/env sh
 #
 # Send messages to the given kafka topic (default: local--hello-world)
 #
 # Usage:
 #
 # ./scripts/cluster/events/send  # default: local--hello-world
 # ./scripts/cluster/events/send example-topic
+set -e
 
 topic_name="${1:-local--hello-world}"
 

scripts/cluster/logs

@@ -1,3 +1,4 @@
-#!/bin/sh -e
+#!/usr/bin/env sh
+set -e
 
 docker-compose logs -f

scripts/cluster/restart

@@ -1,4 +1,5 @@
-#!/bin/sh -e
+#!/usr/bin/env sh
+set -e
 
 service="${1:-kafka}"
 docker-compose restart "${service}"

scripts/cluster/start

@@ -1,4 +1,5 @@
-#!/bin/sh -e
+#!/usr/bin/env sh
+set -e
 
 docker-compose up -d
 scripts/cluster/topics/create "local--kstreams"

scripts/cluster/stop

@@ -1,4 +1,5 @@
-#!/bin/sh -e
+#!/usr/bin/env sh
+set -e
 
 docker-compose stop
 docker-compose rm --force -v

scripts/cluster/topics/create

@@ -1,11 +1,12 @@
-#!/bin/sh -e
+#!/usr/bin/env sh
 #
 # Create a new kafka topic
 #
 # Usage:
 # ./scripts/cluster/topics/create "example-topic"
 # ./scripts/cluster/topics/create "example-topic" partitions=3
 #
+set -e
 
 topic_name=$1
 partitions=${2:-1}

scripts/cluster/topics/ls

@@ -1,9 +1,10 @@
-#!/bin/sh -e
+#!/usr/bin/env sh
 #
 # List available topics
 #
 # Usage:
 # ./scripts/cluster/topics/ls
 #
+set -e
 
 docker-compose exec kafka kafka-topics --list --bootstrap-server kafka:9092

scripts/format

@@ -1,4 +1,5 @@
-#!/bin/bash -e
+#!/usr/bin/env bash
+set -e
 
 export PREFIX=""
 if [ -d '.venv' ] ; then

scripts/install

@@ -1,7 +1,8 @@
-#!/bin/bash -e
+#!/usr/bin/env bash
+set -e
 
-PYTHON="${PYTHON:=python3.10}" 
-POETRY_VERSION="${POETRY_VERSION:=1.1.4}" 
+PYTHON="${PYTHON:=python3.10}"
+POETRY_VERSION="${POETRY_VERSION:=1.1.4}"
 PREFIX=".venv/bin/"
 
 $PYTHON -m venv .venv --clear

scripts/publish

@@ -1,4 +1,5 @@
-#!/bin/bash -e
+#!/usr/bin/env bash
+set -e
 
 export PREFIX=""
 if [ -d '.venv' ] ; then

scripts/test

@@ -1,4 +1,5 @@
-#!/bin/bash -e
+#!/usr/bin/env bash
+set -e
 
 export PREFIX=""
 if [ -d '.venv' ] ; then