Add OIDC SSO login and account linking - #17
Open
ACodingGenie wants to merge 2 commits into
Open
Conversation
Author
|
Backend code: koush/scrypted#2077 |
Show OIDC SSO button, username/password form, or both depending on authType returned by checkScryptedClientLogin.
- Fix root-relative /login/oidc and /login/oidc/link paths: use
combineBaseUrl so cloud deployments hit the correct server origin
- Add .catch(() => {}) to Login.vue checkScryptedClientLogin call
- Fix open redirect: validate redirect_uri is same-origin before use
- Fix change_password sending confirmPassword instead of newPassword
- Export oidcEnabled computed from client.ts, removing the duplicate
expression that existed in both Login.vue and AppBar.vue
- Export oidcLinked ref populated from GET /login oidcLinked field;
hide the AppBar link button when already linked
- Replace native title= tooltip with v-tooltip on the link button
- Unify the two v-card-actions blocks in Login.vue into one
- authType typed as string | undefined to reflect server reality
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Wires up the UI for the OIDC authentication backend added to the server. Covers three flows: OIDC-only login, mixed basic+OIDC login, and linking an OIDC identity to an existing local account.