feat(helm): add auto-environment values to k8s-reporter chart#1031
feat(helm): add auto-environment values to k8s-reporter chart#1031mbevc1 wants to merge 7 commits into
Conversation
|
Claude finished @mbevc1's task in 1m 20s —— View job PR Review — Helm auto-environment values
This PR only touches the ✅ Prior review feedback — all addressed
Correctness check
|
0b94b2d to
7513d38
Compare
Expose the CLI's `--auto-environment` flag and its companion flags (`--environment-description`, `--include-scaling`, `--exclude-scaling`) as `reporterConfig.*` values on the k8s-reporter chart, so the reporter CronJob can auto-create Kosli environments (type K8S) on first run without editing the chart. Chart version bumped to 2.6.0 and the values table in README regenerated.
Make reporterConfig.includeScaling nullable (default `null`) so it maps to all three CLI states: unset omits both scaling flags (Kosli server default), true passes `--include-scaling`, and false passes `--exclude-scaling`. The template uses `kindIs "invalid"` to tell an unset value apart from an explicit false, so autoEnvironment no longer forces a scaling flag. Also whitespace-trims the auto-environment arg block so it renders cleanly.
Clarify in the value help text that environmentDescription and
includeScaling apply to every environment auto-created in a single run,
that a single description is shared by all of them, and that existing
environments are never modified (the CLI ignores these flags for envs
that already exist).
Also normalise the args block whitespace: the dryRun and httpProxy
conditionals now use {{- trim markers like the auto-environment block,
so the rendered manifest has no stray blank lines.
Guard the scaling flag with `kindIs "bool"` instead of `not (kindIs "invalid" ...)`. A string value (e.g. from `--set-string reporterConfig.includeScaling=false` or a quoted `includeScaling: "false"`) is Go-template truthy whenever non-empty, which previously emitted --include-scaling regardless of the intended value. Requiring a genuine boolean means any non-bool falls back to the safe "unset -> server default" path.
64be161 to
c058258
Compare
--auto-environmentflag and its companion flags(
--environment-description,--include-scaling,--exclude-scaling)as
reporterConfig.*values on the k8s-reporter chart, so the reporterCronJob can auto-create Kosli environments (type K8S) on first run
without editing the chart.
2.33.3--auto-environmentflag to kosli snapshot #1028