-
Notifications
You must be signed in to change notification settings - Fork 21
chore(deps): update module github.com/golang/protobuf to v1.5.4 - autoclosed #30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -92,7 +92,7 @@ require ( | |
| github.com/goccy/go-json v0.10.2 // indirect | ||
| github.com/gogo/protobuf v1.3.2 // indirect | ||
| github.com/golang/groupcache v0.0.0-20210331224755-41bb18bfe9da // indirect | ||
| github.com/golang/protobuf v1.5.3 // indirect | ||
| github.com/golang/protobuf v1.5.4 // indirect | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. [medium] correctness go.sum is not updated to include checksums for github.com/golang/protobuf v1.5.4. The renovate/artifacts CI status reports "Artifact file update failure" and the lint check is failing. Go builds will fail with -mod=readonly (default) because the required checksum entry is missing. Suggested fix: Run |
||
| github.com/google/s2a-go v0.1.7 // indirect | ||
| github.com/googleapis/enterprise-certificate-proxy v0.3.2 // indirect | ||
| github.com/googleapis/gax-go/v2 v2.12.0 // indirect | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[high] api-contract
go.mod declares github.com/golang/protobuf v1.5.4, but backend/go.sum has no corresponding v1.5.4 entry (it only contains hashes for v1.5.3). The PR changes only backend/go.mod without updating backend/go.sum. This will cause build failures because go build requires a matching checksum entry in go.sum for every declared dependency version.
Suggested fix: Run go mod tidy (or go mod download) inside the backend/ directory so that go.sum is updated with the correct hash for v1.5.4. Commit the resulting go.sum change alongside go.mod.