Skip to content

docs: track upstream PR for archived base.go Unsigned fix #141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
psturc merged 2 commits into from
Aug 10, 2026
+2 −2
Merged

docs: track upstream PR for archived base.go Unsigned fix #141

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1d671a9
docs: link upstream PR for archived base.go Unsigned fix
mfrancisc Aug 4, 2026
98c1990
Merge branch 'main' into updateupstreamdiff
mfrancisc Aug 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions docs/upstream-diffs.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,8 +91,8 @@ failure in golangci-lint for any PR that introduces a new plugin main package.
Replaced `constraints.Unsigned` with a locally-defined `unsignedInteger` interface that has
identical semantics, eliminating the `golang.org/x/exp` import entirely.

**Upstream status:** Pending submission upstream (trivial/safe change)
**Upstream PR:** none yet
**Upstream status:** Submitted (awaiting merge)
**Upstream PR:** https://github.com/apache/devlake/pull/9032
Comment on lines +94 to +95

@qodo-app-for-konflux-ci qodo-app-for-konflux-ci Bot Aug 4, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Action required

1. Changes outside owned plugin dirs 📘 Rule violation ⌂ Architecture

This PR modifies docs/upstream-diffs.md, which is outside the only allowed directories
(backend/plugins/aireview/, backend/plugins/codecov/, backend/plugins/testregistry/). Per
policy, any modifications outside those owned plugin directories violate the rule and should not be
merged as-is.
Agent Prompt 
## Issue description
The PR modifies a file outside the approved owned plugin directories, which violates the policy requiring all changes to be confined to `backend/plugins/aireview/`, `backend/plugins/codecov/`, or `backend/plugins/testregistry/`.

## Issue Context
The changed file is `docs/upstream-diffs.md`, which is not under any of the allowed owned plugin paths.

## Fix Focus Areas
- docs/upstream-diffs.md[46-47]

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

**Owner:** @fmuntean

**Rebase notes:** If upstream changes `GenericModel`, check whether they still reference
Expand Down
Loading