Skip to content

better termination handling #164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
komuw wants to merge 2 commits into
base: master
Choose a base branch
from
Open

better termination handling #164

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
47e1ae3
better term
komuw Sep 14, 2019
571533d
better term
komuw Sep 14, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions cli/utils/sig.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
import os
import signal
import asyncio
import logging
Expand Down Expand Up @@ -33,6 +34,10 @@ async def _signal_handling(
async def _handle_termination_signal(
logger: naz.log.BaseLogger, _signal: "signal.Signals", client: naz.Client
) -> None:
"""
Handle termination signal by cleanly shutting down the `naz` client.
At the end of it, send a `SIGKILL` signal to `naz` to make sure it exists.
"""
logger.log(
logging.INFO,
{
Expand All @@ -49,4 +54,6 @@ async def _handle_termination_signal(
logging.INFO,
{"event": "naz.cli.signals", "stage": "end", "state": "client has succesfully shutdown"},
)

os.kill(client._PID, signal.SIGKILL)
return
1 change: 1 addition & 0 deletions examples/example_config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,4 +18,5 @@
enquire_link_interval=70.00,
rateLimiter=MyRateLimiter(),
address_range="^254", # any msisdns beginning with 254. See Appendix A of SMPP spec doc
logger=naz.log.SimpleLogger("okayy", naz.log.BreachHandler(capacity=30)),
Copy link
Copy Markdown
Owner Author

@komuw komuw Sep 14, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@komuw undo this change

)