Release briefing 4.6#125
Merged
Merged
Conversation
Contributor
Author
|
@romintomasetti would you please give the Graph section a review. |
romintomasetti
requested changes
Apr 3, 2025
romintomasetti
left a comment
romintomasetti
left a comment
There was a problem hiding this comment.
Most comments are related to consistency with the wording in kokkos/kokkos-core-wiki#565.
I'd also want the slides to link to the PRs when they are well contained and a good starting point to discover a new feature :wink
masterleinad
reviewed
Apr 3, 2025
| \begin{itemize} | ||
| \item{Check availability of compilers on your systems} | ||
| \item{Test with C++20 enabled: start with a CPU build} | ||
| \item{Minimum Compiler requirements will change (more details later)} |
Contributor
There was a problem hiding this comment.
It seems we didn't keep a corresponding slide from the 4.4 release briefing.
Contributor
Author
There was a problem hiding this comment.
I am not sure I understand what you are saying
Contributor
There was a problem hiding this comment.
AFAICT, there is no slide addressing "more details later" so we should add one or drop it.
Contributor
Author
Contributor
There was a problem hiding this comment.
Contributor
There was a problem hiding this comment.
We could still require higher versions but that's what we last agreed on for C++20 support.
JBludau
commented
Apr 3, 2025
Co-authored-by: Daniel Arndt <arndtd@ornl.gov>
Co-authored-by: Daniel Arndt <arndtd@ornl.gov>
Co-authored-by: Daniel Arndt <arndtd@ornl.gov>
Co-authored-by: Daniel Arndt <arndtd@ornl.gov>
Co-authored-by: Daniel Arndt <arndtd@ornl.gov>
Co-authored-by: Daniel Arndt <arndtd@ornl.gov>
JBludau
commented
Apr 7, 2025
dalg24
reviewed
Apr 8, 2025
Comment on lines
+73
to
+78
| \textit{List of Applications and Libraries} | ||
| \begin{itemize} | ||
| \item Add your app to \url{https://github.com/kokkos/kokkos/issues/1950} | ||
| \item We are planning to add that to a Kokkos website. | ||
| \item Helps people discover each other when working on similar things. | ||
| \end{itemize} |
Member
There was a problem hiding this comment.
We might want to finally revisit that and point to https://kokkos.org/community/applications/
@crtrott what do you think?
Co-authored-by: Damien L-G <dalg24+github@gmail.com>
Co-authored-by: Damien L-G <dalg24+github@gmail.com>
tcclevenger
reviewed
Apr 9, 2025
Co-authored-by: Thomas Conrad Clevenger <tccleve@sandia.gov>
dalg24
approved these changes
Apr 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
13 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please add your slides to this pr. If you can not push to my fork, contact me.
Changelog for 4.6