-
Notifications
You must be signed in to change notification settings - Fork 67
Better cross-referencing and link validation #827
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from 1 commit
c109981
f37d4df
9491f1d
29bffe9
1cd0d6c
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -417,7 +417,7 @@ Floating point manipulation functions | |
|
|
||
| .. |scalbn| replace:: ``scalbn`` | ||
|
|
||
| .. _scalbln: https://en.cppreference.com/w/cpp/numeric/math/scalbln | ||
| .. _scalbln: https://en.cppreference.com/w/cpp/numeric/math/scalbn | ||
|
|
||
| .. |scalbln| replace:: ``scalbln`` | ||
|
Comment on lines
+420
to
422
|
||
|
|
||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -28,7 +28,7 @@ the clang-format style specified in the repository. | |
|
|
||
| Test configurations are defined in the `kokkos/.jenkins`, and `kokkos/.github/workflows/*` files and determine the official | ||
| primary software stack support. | ||
| The tested compiler versions are also listed [here](https://kokkos.github.io/kokkos-core-wiki/requirements.html). | ||
| The tested compiler versions are also listed [here](../get-started/requirements). | ||
|
||
| These test configurations (sparsely) cover the cross product of hardware platforms (e.g. NVIDIA. Intel, and AMD), | ||
| compilers (e.g. GCC, Clang, NVC++), C++ standards (17-23), Kokkos backends (e.g. Cuda, OpenMP, and HIP) and Kokkos | ||
| configuration options (e.g. Debug, Relocatable Device Code). | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is that going to run as part of the CI?
How expensive is it? Should that be just part of the html rule?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems like we currently don't. But I am for doing it if it is cheap
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It only checks external links, and there are a lot of false positives.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we know how to reduce the false positives?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've just left it there so that developers can use it easily. I don't think it can be included in a CI
need to add the
:doc:tag to some links