Adding Mxx*FirstLoc reducers#692
Open
nliber wants to merge 12 commits into
Open
Conversation
Added defaulted HostSpace
Added deduction guides
Minor cleanup of text and formatting
the smallest index for duplicate equivalent values
MinMaxFirstLastLoc.
nliber
force-pushed
the
MxxFirstLoc-reducers
branch
from
9b1673a to
58a18a4
Compare
dalg24
reviewed
Jul 21, 2025
|
|
||
| .. rubric:: Constructors: | ||
|
|
||
| .. cpp:function:: MaxFirstLoc(value_type& value_); |
Member
There was a problem hiding this comment.
KOKKOS_FUNCTION annotations are missing
Same comment everywhere below
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is to address kokkos/kokkos#8097 and partially address #690.
Added new documentation for
MaxFirstLoc,MinFirstLocandMinMaxFirstLastLoc.This documentation is a bit cleaner and more complete (includes defaulted
HostSpace,references_scalar()and CTAD) than the existingMaxLoc, etc.. After this stabilizes, I'll updateMaxLoc, etc. (and probably others) under a separate PR.Added notes to
MaxLoc, etc. about those who want a specific index for duplicate equivalent values should useMaxFirstLoc, etc. instead.This note is under the description of
join.