Target Android 16 (API 36) - #212
Merged
Merged
Conversation
Play requires API 36 to keep publishing updates. compileSdk was already 36, and the behaviour changes that come with targeting it are all already handled: the app draws edge-to-edge, opts into predictive back, and never restricted orientation or resizability.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe Android app’s ChangesAndroid SDK configuration
Estimated code review effort: 1 (Trivial) | ~2 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Play Console: "Your highest non-compliant target API level is Android 15 (API level 35). To ensure that you can continue to make updates to your app you must update your app to target Android 16 (API level 36) or higher."
compileSdkwas already 36, so this is the one line that was left.Why this is low-risk here
The behaviour changes that come with targeting 36 are all already accounted for:
MainActivity.onCreatecallssetDecorFitsSystemWindows(window, false)enableOnBackInvokedCallback="true"; back nav was fixed in #152screenOrientationnorresizeableActivityforegroundServiceType="mediaPlayback"with the matching permission already declaredVerified
Bundle manifest from the release build:
versionCode 500 is
50 * 10 + 0from the ABI scheme inbuild.gradle:98, consistent with build 47 having shipped as 470.Not verified on an Android device. This changes runtime behaviour opt-ins; it wants a smoke test on hardware — launch, playback, back gesture, notification controls — before going to production. Play's internal testing track is the natural place.
Summary by CodeRabbit