Skip to content

[MEDIUM] Classify rooted IPs and bound hostname normalization #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
OskarEichler wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[MEDIUM] Classify rooted IPs and bound hostname normalization #41

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 19 additions & 2 deletions lib/domain_name.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,8 @@ def canonical?
end

DOT = '.' # :nodoc:
MAX_HOSTNAME_LENGTH = 253 # :nodoc:
MAX_LABEL_LENGTH = 63 # :nodoc:

# Parses _hostname_ into a DomainName object. An IP address is also
# accepted. An IPv6 address may be enclosed in square brackets.
Expand All @@ -81,7 +83,11 @@ def initialize(hostname)
if hostname.start_with?(DOT)
raise ArgumentError, "domain name must not start with a dot: #{hostname}"
end
case hostname
address = hostname.chomp(DOT)
if address.length > MAX_HOSTNAME_LENGTH
raise ArgumentError, "domain name is too long: #{hostname}"
end
case address
when /\A([0-9]+\.[0-9]+\.[0-9]+\.[0-9]+)\z/
@ipaddr = IPAddr.new($1)
@uri_host = @hostname = @ipaddr.to_s
Expand Down Expand Up @@ -283,8 +289,19 @@ class << self
def normalize(domain)
chomped = domain.chomp(DOT)
normalized = chomped.ascii_only? ? chomped : chomped.unicode_normalize(:nfc)
if normalized.length > MAX_HOSTNAME_LENGTH
raise ArgumentError, "domain name is too long: #{domain}"
end
if normalized.split(DOT, -1).any? { |label| label.length > MAX_LABEL_LENGTH }
raise ArgumentError, "domain label is too long: #{domain}"
end

DomainName::Punycode.encode_hostname(normalized).downcase
hostname = DomainName::Punycode.encode_hostname(normalized).downcase
if hostname.bytesize > MAX_HOSTNAME_LENGTH ||
hostname.split(DOT, -1).any? { |label| label.bytesize > MAX_LABEL_LENGTH }
raise ArgumentError, "encoded domain name is too long: #{domain}"
end
hostname
end
end
end
Expand Down