fix: prevent nil pointer crash in BounceWebhook when bounce processing disabled#2993
Open
Koushik-1729 wants to merge 1 commit intoknadh:masterfrom
Open
fix: prevent nil pointer crash in BounceWebhook when bounce processing disabled#2993Koushik-1729 wants to merge 1 commit intoknadh:masterfrom
Koushik-1729 wants to merge 1 commit intoknadh:masterfrom
Conversation
…g disabled Adds a nil check for a.bounce at the start of BounceWebhook to return HTTP 503 instead of crashing with a nil pointer dereference when bounce processing is not enabled. Fixes knadh#2983
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
a.bounceat the start ofBounceWebhookFixes #2983
Root Cause
Commit f1649b3 changed validation from config booleans to nil checks on bounce manager fields. When
bounce.enabledis false,a.bounceis never instantiated, causing a nil pointer crash on any webhook request to/api/webhooks/bounce/:service.Changes
a.bounceat the beginning ofBounceWebhookincmd/bounce.gohttp.StatusServiceUnavailable(503) with an appropriate error message when bounce processing is not enabledTesting
bounce.enabled = false: webhook requests return 503 instead of crashingbounce.enabled = true: no behavioral change, existing flow unchanged