Outlook-safe rendering for visual email builder output#2978
Open
MrJoky wants to merge 4 commits intoknadh:masterfrom
Open
Outlook-safe rendering for visual email builder output#2978MrJoky wants to merge 4 commits intoknadh:masterfrom
MrJoky wants to merge 4 commits intoknadh:masterfrom
Conversation
added 2 commits
March 30, 2026 14:58
Keep the last visual builder source/body snapshot when switching between visual and raw formats so unchanged visual content can round-trip without losing button styling or other builder-specific structure.
Move the visual email post-processing into a dedicated outlook module, add Outlook-safe wrappers for buttons, images, text blocks, and spacers, and add a local ESLint config for the email-builder TypeScript subproject so its TS/TSX files are parsed with the correct parser.
Owner
|
Thanks @MrJoky. This is a big PR, which is going to be very difficult for me to test and verify. Would you be able to share screenshots+HTML of e-mails post-processed via this rendering in Outlook and non-Outlook clients? |
Author
Author
|
@knadh how far are you with the review? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improves Outlook compatibility for emails created with the visual email builder.
It adds Outlook-oriented post-processing to the visual builder HTML output so that buttons, images, text blocks, and
spacers render more reliably in Outlook. It also fixes format switching in the campaign editor so that switching
between
visualandraw/htmldoes not discard the visual builder source for unchanged content.References: #2576
Not sure if this issue addresses the same problem #1231