Skip to content

[FEATURE] Remove TODO for passing state #946

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
beatrycze-volk wants to merge 78 commits into
base: 6.x
Choose a base branch
from

Fix navigation links

f8d3b9f
Select commit
Loading
Failed to load commit list.
Draft

[FEATURE] Remove TODO for passing state #946

Fix navigation links
f8d3b9f
Select commit
Loading
Failed to load commit list.
Codacy Production / Codacy Static Code Analysis succeeded Nov 7, 2025 in 0s

Your pull request is up to standards!

Codacy Here is an overview of what got changed by this pull request:

Issues
======
+ Solved 10
- Added 15
           

Complexity increasing per file
==============================
- Classes/Common/IiifManifest.php  9
- Classes/Common/MetsDocument.php  11
- Classes/Controller/TableOfContentsController.php  3
- Classes/Controller/NavigationController.php  1
- Classes/Controller/MetadataController.php  5
- Tests/Functional/Common/SolrIndexingTest.php  6
- Classes/Controller/DocumentController.php  11
- Resources/Public/JavaScript/PageView/PageView.js  15
- Resources/Public/JavaScript/PageView/Navigation.js  22
- Resources/Public/JavaScript/PageView/Controller.js  38
- Resources/Public/JavaScript/PageView/Metadata.js  14
- Resources/Public/JavaScript/PageView/TableOfContents.js  17
- Resources/Public/JavaScript/PageView/Toolbox.js  17
- Classes/Common/AbstractDocument.php  25
         

Complexity decreasing per file
==============================
+ Classes/Controller/ToolboxController.php  -9

See the complete overview on Codacy

Annotations

Check warning on line 11 in Resources/Public/JavaScript/PageView/Controller.js

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

Resources/Public/JavaScript/PageView/Controller.js#L11 

'dlfController' is defined but never used.

Check warning on line 106 in Resources/Public/JavaScript/PageView/Controller.js

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

Resources/Public/JavaScript/PageView/Controller.js#L106 

'dlfUtils' is not defined.

Check warning on line 106 in Resources/Public/JavaScript/PageView/Controller.js

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

Resources/Public/JavaScript/PageView/Controller.js#L106 

Method 'findFileByGroup' expected no return value.

Check warning on line 30 in Resources/Public/JavaScript/PageView/Metadata.js

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

Resources/Public/JavaScript/PageView/Metadata.js#L30 

'dlfMetadata' is defined but never used.

Check notice on line 106 in Resources/Public/JavaScript/PageView/Metadata.js

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

Resources/Public/JavaScript/PageView/Metadata.js#L106 

Default clause should be the last clause.

Check warning on line 11 in Resources/Public/JavaScript/PageView/Navigation.js

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

Resources/Public/JavaScript/PageView/Navigation.js#L11 

'dlfNavigation' is defined but never used.

Check warning on line 43 in Resources/Public/JavaScript/PageView/Navigation.js

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

Resources/Public/JavaScript/PageView/Navigation.js#L43 

'prevPageNo' is defined but never used.

Check warning on line 55 in Resources/Public/JavaScript/PageView/Navigation.js

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

Resources/Public/JavaScript/PageView/Navigation.js#L55 

'prevPageNo' is defined but never used.

Check warning on line 355 in Resources/Public/JavaScript/PageView/PageView.js

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

Resources/Public/JavaScript/PageView/PageView.js#L355 

'dlfViewerFullTextControl' is not defined.

Check warning on line 358 in Resources/Public/JavaScript/PageView/PageView.js

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

Resources/Public/JavaScript/PageView/PageView.js#L358 

'dlfViewerFullTextDownloadControl' is not defined.

Check notice on line 368 in Resources/Public/JavaScript/PageView/PageView.js

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

Resources/Public/JavaScript/PageView/PageView.js#L368 

.catch is a syntax error.

Check warning on line 17 in Resources/Public/JavaScript/PageView/TableOfContents.js

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

Resources/Public/JavaScript/PageView/TableOfContents.js#L17 

'dlfTableOfContents' is defined but never used.

Check warning on line 52 in Resources/Public/JavaScript/PageView/TableOfContents.js

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

Resources/Public/JavaScript/PageView/TableOfContents.js#L52 

'e' is defined but never used.

Check warning on line 11 in Resources/Public/JavaScript/PageView/Toolbox.js

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

Resources/Public/JavaScript/PageView/Toolbox.js#L11 

'dlfToolbox' is defined but never used.

Check warning on line 69 in Resources/Public/JavaScript/PageView/Toolbox.js

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

Resources/Public/JavaScript/PageView/Toolbox.js#L69 

Expected a default case.
View more details on Codacy Production