Skip to content

[MAINTENANCE] Use Extbase Query API in MetadataRepository::findWithoutFormat#1974

Open
beatrycze-volk wants to merge 3 commits into
kitodo:mainfrom
beatrycze-volk:metadata-repository-2
Open

[MAINTENANCE] Use Extbase Query API in MetadataRepository::findWithoutFormat#1974
beatrycze-volk wants to merge 3 commits into
kitodo:mainfrom
beatrycze-volk:metadata-repository-2

Conversation

@beatrycze-volk
Copy link
Copy Markdown
Collaborator

No description provided.

…d ::findWithoutFormat

Adds functional test cases to verify the correct behavior of the new `findWithFormat` and `findWithoutFormat` methods within the `MetadataRepository`. These tests ensure data retrieval is accurate when filtering by format.
…tFormat

Refactors the `findWithoutFormat` method to leverage the Extbase Query API, moving away from direct Doctrine DBAL QueryBuilder usage. This aligns the repository with Extbase best practices for querying and working with domain models.

The `pid` parameter has also been removed from the method signature, and results are now mapped from Extbase objects.
@beatrycze-volk beatrycze-volk self-assigned this May 12, 2026
@beatrycze-volk beatrycze-volk added the ⟳ maintenance A task to keep the code up-to-date and manageable. label May 12, 2026
@beatrycze-volk beatrycze-volk marked this pull request as draft May 12, 2026 14:20
@beatrycze-volk beatrycze-volk force-pushed the metadata-repository-2 branch from 734aba2 to 038c290 Compare May 12, 2026 17:15
@beatrycze-volk beatrycze-volk marked this pull request as ready for review May 12, 2026 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

⟳ maintenance A task to keep the code up-to-date and manageable.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants