[MAINTENANCE] Typo3 v13 support#1686
Conversation
…fers between v12 and v13.
…v13 update. Fix backend index command.
…for Typo3 v13 compatibility.
…s not considered.
… typo3-v13-support
…ssage icon rendering which is not allowed and causes RuntimeError.
… which is not available in Typo3 v12 to prevent autowire error.
sebastian-meyer
left a comment
There was a problem hiding this comment.
Excellent work! Thank you very much!
| ], | ||
| ]); | ||
| $xml = new SimpleXMLElement((string) $response->getBody()); | ||
| $client = new OaiPmhTypo3Client($this->baseUrl, $this->oaiPage, $this, false); |
There was a problem hiding this comment.
@thomaslow, @sebastian-meyer, this new code is missing in the 6.x branch. Should it be identical to the main branch?
There was a problem hiding this comment.
@stweil I am not sure what you mean. The OaiPmhTypo3Client was added as part of the Typo3 v13 update because there was an incompatibility due to the disableJsonWrappedResponse setting. This setting instructs Typo3 v11/v12 to return the response of the OaiPmhController as raw XML (instead of wrapped in JSON) such that it can be parsed by the external library Phpoaipmh (which doesn't know anything about Typo3 responses). This was not possible in Typo3 v13 any more, which is why I implemented the additional class.
There was a problem hiding this comment.
Ah, sorry, I was confused about the different releases. I assumed that 6.x should support TYPO3 v13, but it only supports v11 and v12. The main branch and a future 7.x support TYPO3 v13.
The following pull request drops support for Typo3 v11 and updates Kitodo.Presentation for Typo3 v13.
Related Issues:
Includes Pull Requests:
Blocked by:
Todo
Mandatory
Maybe
Test with DFG viewerChanges
^12.4|^13.4PHP 8.2 required due tosymfony/process>=7.0required for Typo3 v13.4ext_tables.php(used in v11) which was replaced byConfiguration/Backend/Modules.phpin v12+GeneralUtility::_GET()withServerRequestInterface, see Deprecation #100596ModuleTemplate, see Feature #96730storagePidinItemsProcFunc.php, see Deprecation #99020, maybe use Site Settings in the future?QueryBuilder::execute, see Deprecation #96972fetchcalls due to DBAL v3 update, see Breaking #96287add('orderBy')toorderBy(), see QueryBuilder::addandX,orXtoand,or, see Deprecation #97354$GLOBALS['TSFE']->fe_user, see Breaking #102605languageService->getLL(...)translation method tolanguageService->sL(...), see Deprecation #100721FlashMessageenum toContextualFeedbackSeverityenum, see Deprecation #97787KitodoFlashMessageRenderermarkup rendering based on typo3BootstrapRendererwithout icon, because icon markup is not allowed when rendering form fields and triggeres a runtime exceptionjson_responseframework extension, which doesn't work in Typo3 testing framework v8+, see Code Snippet.pages.xmltopages.csvbecause XML-based fixture loader was removed in Typo3 testing framework v8+, see documentationGeneralUtility::_GPto$request->getQueryParamsin OaiPmhController, see Deprecation #100053.Bootstrap::initializeLanguageObject()see, commitTypoScriptParserinMetadataWrapVariableViewHelperdue to Deprecation #99120ConfigurationManager::getContentObjectdue to Deprecation #100662strptimewithDateTime::createFromFormatin OaiPmhController, see PHPinternal_typeoption which is not evaluated any more, see Deprecation #96983requiredoption fromevallist to separate option, see Deprecation #97035inputtodateTime, see Feature #97232 and Documentationinputtonumber, see Feature #97193 and Documentationcruser_idwhich is not evaluated any more, see Breaking #98024itemsoption to associative array, see Feature #99739\PDO::PARAM_*toConnection::PARAM_*, see documentation