Skip to content

Support connection_pool 3.x - #41

Open
NotFounds wants to merge 1 commit into
kigster:mainfrom
NotFounds:support-connection-pool-3
Open

Support connection_pool 3.x#41
NotFounds wants to merge 1 commit into
kigster:mainfrom
NotFounds:support-connection-pool-3

Conversation

@NotFounds

Copy link
Copy Markdown

Hello, thank you for providing this great library.

To support version 3.x, this PR relaxes the dependency for connection_pool to >= 2, < 4.

SimpleFeed only uses ConnectionPool.new(size:) and pool.with, neither of which has changed in version 3.0.

BREAKING CHANGES ConnectionPool and ConnectionPool::TimedStack now use keyword arguments rather than positional arguments everywhere. Expected impact is minimal as most people use the with API, which is unchanged.

ref. https://github.com/mperham/connection_pool/blob/main/Changes.md#300

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant